From: Christoph Hellwig <hch@infradead.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH x86/mm 4/6] x86-64 ptrace get/putreg current task
Date: Thu, 29 Nov 2007 17:39:44 +0000 [thread overview]
Message-ID: <20071129173944.GB556@infradead.org> (raw)
In-Reply-To: <20071129004118.D317B26F8E7@magilla.localdomain>
On Wed, Nov 28, 2007 at 04:41:18PM -0800, Roland McGrath wrote:
>
> This generalizes the getreg and putreg functions so they can be used on the
> current task, as well as on a task stopped in TASK_TRACED and switched off.
> This lays the groundwork to share this code for all kinds of user-mode
> machine state access, not just ptrace.
Not sure it's a that good idea as it means almost every case now has
a branch for two entirely separate cases. Wouldn't it be better to have
a separate helper for the looking at the current proces case?
Either way support for looking at the current thread should only be
merged together with an actual user for that.
next prev parent reply other threads:[~2007-11-29 17:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 0:38 [PATCH x86/mm 1/6] x86-64 ia32 ptrace pt_regs cleanup Roland McGrath
2007-11-29 0:40 ` [PATCH x86/mm 2/6] x86-64 ptrace whitespace Roland McGrath
2007-11-29 0:40 ` [PATCH x86/mm 3/6] x86-32 " Roland McGrath
2007-11-29 0:41 ` [PATCH x86/mm 4/6] x86-64 ptrace get/putreg current task Roland McGrath
2007-11-29 17:39 ` Christoph Hellwig [this message]
2007-11-29 0:42 ` [PATCH x86/mm 5/6] x86-32 " Roland McGrath
2007-11-29 0:42 ` [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 " Roland McGrath
2007-11-29 17:34 ` Chuck Ebbert
2007-11-29 18:09 ` Linus Torvalds
2007-11-29 18:16 ` H. Peter Anvin
2007-11-29 18:31 ` Linus Torvalds
2007-11-29 18:45 ` H. Peter Anvin
2007-11-29 19:08 ` Linus Torvalds
2007-11-29 19:16 ` H. Peter Anvin
2007-11-29 19:27 ` Andi Kleen
2007-11-29 19:44 ` Ingo Molnar
2007-11-29 20:01 ` H. Peter Anvin
2007-12-01 23:44 ` Jeremy Fitzhardinge
2007-11-29 19:49 ` Linus Torvalds
2007-11-29 20:11 ` Andi Kleen
2007-11-29 20:23 ` Linus Torvalds
2007-11-29 18:17 ` Chuck Ebbert
2007-11-29 18:23 ` H. Peter Anvin
2007-11-29 22:25 ` Roland McGrath
2007-11-29 22:34 ` Linus Torvalds
2007-11-29 22:21 ` Roland McGrath
2007-11-29 23:00 ` Chuck Ebbert
2007-11-29 10:39 ` [PATCH x86/mm 1/6] x86-64 ia32 ptrace pt_regs cleanup Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071129173944.GB556@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®