mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: akpm@linux-foundation.org
Cc: dhowells@redhat.com, linux-am33-list@redhat.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/9] USB: net2280 can't have a function called show_registers() [2.6.24-rc3-mm2]
Date: Thu, 29 Nov 2007 22:52:40 +0000	[thread overview]
Message-ID: <20071129225240.21536.25336.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20071129225219.21536.58653.stgit@warthog.procyon.org.uk>

net2280 can't have a function called show_registers() because this can produce
a namespace clash with an arch function of the same name.

All this driver's functions and variables should really be prefixed with
"net2280_" to avoid such a problem in future.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 drivers/usb/gadget/net2280.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 33469cf..e018623 100644
--- a/drivers/usb/gadget/net2280.c
+++ b/drivers/usb/gadget/net2280.c
@@ -1418,8 +1418,8 @@ show_function (struct device *_dev, struct device_attribute *attr, char *buf)
 }
 static DEVICE_ATTR (function, S_IRUGO, show_function, NULL);
 
-static ssize_t
-show_registers (struct device *_dev, struct device_attribute *attr, char *buf)
+static ssize_t net2280_show_registers(struct device *_dev,
+				struct device_attribute *attr, char *buf)
 {
 	struct net2280		*dev;
 	char			*next;
@@ -1571,7 +1571,7 @@ show_registers (struct device *_dev, struct device_attribute *attr, char *buf)
 
 	return PAGE_SIZE - size;
 }
-static DEVICE_ATTR (registers, S_IRUGO, show_registers, NULL);
+static DEVICE_ATTR(registers, S_IRUGO, net2280_show_registers, NULL);
 
 static ssize_t
 show_queues (struct device *_dev, struct device_attribute *attr, char *buf)


  parent reply	other threads:[~2007-11-29 22:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 22:52 [PATCH 1/9] AOUT: Move STACK_TOP[_MAX] to asm/processor.h [2.6.24-rc3-mm2] David Howells
2007-11-29 22:52 ` [PATCH 2/9] AOUT: Mark arches that support A.OUT format [2.6.24-rc3-mm2] David Howells
2007-11-29 22:52 ` [PATCH 3/9] AOUT: Suppress A.OUT library support if !CONFIG_ARCH_SUPPORTS_AOUT [2.6.24-rc3-mm2] David Howells
2007-11-29 22:52 ` [PATCH 4/9] AOUT: Remove unnecessary inclusions of {asm, linux}/a.out.h [2.6.24-rc3-mm2] David Howells
2007-11-29 22:52 ` David Howells [this message]
2007-11-29 22:52 ` [PATCH 6/9] MN10300: Allocate serial port UART IDs for on-chip serial ports [2.6.24-rc3-mm2] David Howells
2007-11-29 22:52 ` [PATCH 8/9] MN10300: Add platform MTD support for the ASB2303 board [2.6.24-rc3-mm2] David Howells
2007-11-29 22:53 ` [PATCH 9/9] MN10300: Fix MTD JEDEC probe so that the ASB2303 bootprom can be detected [2.6.24-rc3-mm2] David Howells
2007-11-30 13:46   ` David Woodhouse
2007-11-30 14:01   ` David Howells
2007-11-30 15:06     ` David Woodhouse
2007-11-30 17:12     ` David Woodhouse
2007-11-30 14:13 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129225240.21536.25336.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-am33-list@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®