mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: cbou@mail.ru
Cc: Jochen Friedrich <jochen@scram.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jeff Garzik <jeff@garzik.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality
Date: Sun, 2 Dec 2007 10:27:39 +1100	[thread overview]
Message-ID: <20071202102739.490ae468.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20071201213403.GA2350@zarina>

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Just a little reminder ...

On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov <cbou@mail.ru> wrote:
>
> static int __init of_add_fixed_phys(void)
> {
> 	struct device_node *np;
> 	const u32 *prop;
> 	struct fixed_phy_status status = {};
> 
> 	while ((np = of_find_node_by_name(NULL, "ethernet"))) {

	for_each_node_by_name(np, "ethernet") {
(this probably does what you want instead of finding just the first
ethernet over and over again. :-))

> 		data  = of_get_property(np, "fixed-link", NULL);
> 		if (!data)
> 			continue;
> 
> 		status.link = 1;
> 		status.duplex = data[1];
> 		status.speed  = data[2];
> 
> 		ret = fixed_phy_add(PHY_POLL, data[0], &status);
> 		if (ret)
> 			return ret;
		if (ret) {
			of_put_node(np);
			retun ret;
		}
> 	}

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2007-12-01 23:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 14:29 Vitaly Bordug
2007-11-26 14:29 ` [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property Vitaly Bordug
2007-11-26 15:04   ` [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar forfixed-link property Joakim Tjernlund
2007-11-27 11:39     ` [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property Anton Vorontsov
2007-11-27 13:17       ` Joakim Tjernlund
2007-11-27 13:59         ` Anton Vorontsov
2007-11-27 14:01           ` Joakim Tjernlund
2007-11-26 14:29 ` [PATCH 3/3] [POWERPC] MPC8349E-mITX: Vitesse 7385 PHY is not connected to the MDIO bus Vitaly Bordug
2007-12-01 13:48 ` [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Jochen Friedrich
2007-12-01 19:07   ` Vitaly Bordug
2007-12-01 21:34   ` Anton Vorontsov
2007-12-01 22:22     ` Vitaly Bordug
2007-12-01 23:27     ` Stephen Rothwell [this message]
2007-12-02 11:54     ` [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHYlayer functionality Joakim Tjernlund
2007-12-02 12:13       ` Anton Vorontsov
2007-12-01 21:59 ` [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Jeff Garzik
2007-12-01 22:16   ` Vitaly Bordug
2007-12-04 20:07 ` Jeff Garzik
2007-12-05  1:22   ` Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071202102739.490ae468.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=cbou@mail.ru \
    --cc=jeff@garzik.org \
    --cc=jochen@scram.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®