From: Richard Knutsson <ricknu-0@student.ltu.se>
To: hverkuil@xs4all.nl, mchehab@infradead.org
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: [PATCH 2/2] ivtv: Remove a invalid shadow-variable
Date: Sun, 2 Dec 2007 18:47:01 +0100 (MET) [thread overview]
Message-ID: <20071202173335.15374.10234.sendpatchset@thinktank.campus.ltu.se> (raw)
In-Reply-To: <20071202173329.15374.4223.sendpatchset@thinktank.campus.ltu.se>
Remove the shadowing 'struct v4l2_chip_ident *chip', since it already exists
and makes the if-statement useless.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Compile-tested on i386 with "allyesconfig" and "allmodconfig".
diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c b/drivers/media/video/ivtv/ivtv-ioctl.c
index fd6826f..874aa22 100644
--- a/drivers/media/video/ivtv/ivtv-ioctl.c
+++ b/drivers/media/video/ivtv/ivtv-ioctl.c
@@ -660,11 +660,8 @@ static int ivtv_debug_ioctls(struct file *filp, unsigned int cmd, void *arg)
chip->ident = V4L2_IDENT_NONE;
chip->revision = 0;
if (reg->match_type == V4L2_CHIP_MATCH_HOST) {
- if (v4l2_chip_match_host(reg->match_type, reg->match_chip)) {
- struct v4l2_chip_ident *chip = arg;
-
+ if (v4l2_chip_match_host(reg->match_type, reg->match_chip))
chip->ident = itv->has_cx23415 ? V4L2_IDENT_CX23415 : V4L2_IDENT_CX23416;
- }
return 0;
}
if (reg->match_type == V4L2_CHIP_MATCH_I2C_DRIVER)
next prev parent reply other threads:[~2007-12-02 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 17:46 [PATCH 1/2] ivtv: Some general fixes Richard Knutsson
2007-12-02 17:47 ` Richard Knutsson [this message]
2007-12-02 19:43 ` [v4l-dvb-maintainer] [PATCH 2/2] ivtv: Remove a invalid shadow-variable Hans Verkuil
2007-12-02 19:49 ` [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes Hans Verkuil
2007-12-02 22:06 ` Richard Knutsson
2007-12-03 11:52 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202173335.15374.10234.sendpatchset@thinktank.campus.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome