From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux@bohmer.net, jonathan@jonmasters.org
Subject: Re: [PATCH] isapnp driver semaphore to mutex
Date: Mon, 3 Dec 2007 17:47:51 +0100 [thread overview]
Message-ID: <20071203164751.GB16135@elte.hu> (raw)
In-Reply-To: <1196697144.1568.1.camel@jnielson-xp.ddns.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
> > * Daniel Walker <dwalker@mvista.com> wrote:
> >
> > > Changed the isapnp semaphore to a mutex.
> >
> > cool - i'll give it a whirl.
> >
> > small immaterial nit:
> >
> > > Signed-Off-By: Daniel Walker <dwalker@mvista.com>
> >
> > it's Signed-off-by (note the capitalization). Having this consistent
> > makes scripting around patches a tiny bit easier.
>
> Yeah, I know about it but sometimes still slips by..
it's worth automating these repetative bits. I use small templates when
creating patches. Also, it's worth running patches through
scripts/checkpatch.pl - it has a check for exactly this typo. [ Not a
big issue at all, i just mentioned it in case you get a taste for
sending more sem2mutex patches :-) ]
Ingo
next prev parent reply other threads:[~2007-12-03 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071203153743.119714913@mvista.com>
2007-12-03 15:38 ` Daniel Walker
2007-12-03 15:57 ` Ingo Molnar
2007-12-03 15:52 ` Daniel Walker
2007-12-03 16:47 ` Ingo Molnar [this message]
2007-12-03 18:35 ` Daniel Walker
2007-12-03 19:11 ` Michal Schmidt
2007-12-03 19:20 ` Daniel Walker
2007-12-03 19:25 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203164751.GB16135@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@bohmer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®