mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Natalie Protasevich <protasnb@gmail.com>, Andi Kleen <ak@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386 IOAPIC: de-fang IRQ compression
Date: Tue, 4 Dec 2007 13:26:49 +0100	[thread overview]
Message-ID: <20071204122649.GB27286@elte.hu> (raw)
In-Reply-To: <200711280121.18376.lenb@kernel.org>


* Len Brown <lenb@kernel.org> wrote:

>     So while the irq compression code on i386 should really
>     be deleted -- even before merging the x86_64 irq-overhaul,
>     this patch simply disables it on all high volume systems
>     to avoid problems #1 and #2 on most all i386 systems.
>     
>     A large system with pin numbers >=64 will still have compression
>     to conserve limited IRQ numbers for sparse IOAPICS.  However,
>     the vast majority of the planet, those with only pin numbers < 64
>     will use an identity GSI -> IRQ mapping.
>     
>     Signed-off-by: Len Brown <len.brown@intel.com>

thanks for the patch and the extensive description. I've applied this to 
x86.git. Do you agree that this has no urgency for v2.6.24 and is thus 
v2.6.25 material?

would you be interested in doing a follow-up patch as well that just 
yanks all of the irq compression code? That would keep things nicely 
bisectable and testable - the second, larger patch would be a NOP in 
theory on most systems.

	Ingo

  parent reply	other threads:[~2007-12-04 12:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28  6:21 Len Brown
2007-11-28  7:09 ` Eric W. Biederman
2007-12-04 12:26 ` Ingo Molnar [this message]
2007-12-04 18:46   ` Eric W. Biederman
2007-12-04 20:55   ` Christian Kujau
2007-12-04 21:28     ` Ingo Molnar
2007-12-05  0:39   ` Andrew Morton
2007-12-05  9:48     ` Ingo Molnar
2007-12-07  2:41       ` Len Brown
2007-12-07 19:16         ` Eric W. Biederman
2007-12-07 20:26           ` Ingo Molnar
2007-12-07 20:31             ` Ingo Molnar
2007-12-07 21:09             ` Eric W. Biederman
2007-12-05 13:25 ` Natalie Protasevich
2007-12-05 23:25   ` Eric W. Biederman
2007-12-05 23:48     ` Natalie Protasevich
2007-12-06  2:20       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071204122649.GB27286@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=protasnb@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®