From: Christoph Hellwig <hch@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Roland McGrath <roland@redhat.com>,
David Smith <dsmith@redhat.com>
Subject: Re: [patch 2/2] Linux Kernel Markers - Create modpost file
Date: Tue, 4 Dec 2007 18:57:44 +0000 [thread overview]
Message-ID: <20071204185744.GB21568@infradead.org> (raw)
In-Reply-To: <20071204182403.319351701@polymtl.ca>
On Tue, Dec 04, 2007 at 01:18:47PM -0500, Mathieu Desnoyers wrote:
> This adds some new magic in the MODPOST phase for CONFIG_MARKERS.
> Analogous to the Module.symvers file, the build will now write a
> Module.markers file when CONFIG_MARKERS=y is set. This file lists
> the name, defining module, and format string of each marker,
> separated by \t characters. This simple text file can be used by
> offline build procedures for instrumentation code, analogous to
> how System.map and Module.symvers can be useful to have for
> kernels other than the one you are running right now.
>
> The strings are made easy to extract by having the __trace_mark macro
> define the name and format together in a single array called __mstrtab_*
> in the __markers_strings section. This is straightforward and reliable
> as long as the marker structs are always defined by this macro. It is
> an unreasonable amount of hairy work to extract the string pointers from
> the __markers section structs, which entails handling a relocation type
> for every machine under the sun.
Generating something like this might make sense. But until you actually
add ome example code, e.g. to generate a tracing module for each probe
marker in a given module I don't see any point in adding this.
next prev parent reply other threads:[~2007-12-04 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 18:18 [patch 0/2] Linux Kernel Markers updates Mathieu Desnoyers
2007-12-04 18:18 ` [patch 1/2] Linux Kernel Markers - Support Multiple Probes Mathieu Desnoyers
2007-12-04 18:55 ` Christoph Hellwig
2007-12-04 20:03 ` Frank Ch. Eigler
2007-12-04 19:06 ` Andrew Morton
2007-12-04 19:21 ` Mathieu Desnoyers
2007-12-04 19:39 ` Andrew Morton
2007-12-04 19:45 ` Mathieu Desnoyers
2007-12-17 17:40 ` Paul E. McKenney
2007-12-20 14:25 ` Mathieu Desnoyers
2007-12-21 17:18 ` Paul E. McKenney
2007-12-17 18:45 ` Paul E. McKenney
2007-12-20 15:09 ` Mathieu Desnoyers
2007-12-04 18:18 ` [patch 2/2] Linux Kernel Markers - Create modpost file Mathieu Desnoyers
2007-12-04 18:57 ` Christoph Hellwig [this message]
2007-12-04 19:10 ` Andrew Morton
2007-12-04 19:15 ` Mathieu Desnoyers
2007-12-04 19:22 ` Christoph Hellwig
2007-12-04 21:34 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204185744.GB21568@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dsmith@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®