From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbXLEDtY (ORCPT ); Tue, 4 Dec 2007 22:49:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750954AbXLEDtP (ORCPT ); Tue, 4 Dec 2007 22:49:15 -0500 Received: from rgminet01.oracle.com ([148.87.113.118]:55989 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbXLEDtP (ORCPT ); Tue, 4 Dec 2007 22:49:15 -0500 Date: Tue, 4 Dec 2007 19:47:19 -0800 From: Randy Dunlap To: Linus Torvalds Cc: Steven Rostedt , Ingo Molnar , Thomas Gleixner , LKML , David Holmes - Sun Microsystems , Andrew Morton Subject: Re: [PATCH -v2] fix for futex_wait signal stack corruption Message-Id: <20071204194719.e048ebc1.randy.dunlap@oracle.com> In-Reply-To: References: <1196801858.1645.37.camel@localhost.localdomain> <20071204213924.GA14915@goodmis.org> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.4.7 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Dec 2007 19:41:32 -0800 (PST) Linus Torvalds wrote: > > Patch looks fine to me. > > On Tue, 4 Dec 2007, Steven Rostedt wrote: > > > > Note: I'm a bit nervious to add "linux/types.h" and use u32 and u64 > > in thread_info.h, when there's a #ifdef __KERNEL__ just below that. > > Not sure what that is there for. > > Hmm. I'd not expect user-mode headers to ever include > , and if they do, they'd already get get totally > invalid namespace pollution ("struct restart_block" at a minimum) along > with stuff that simply isn't sensible in user-space at all, so I think > this part is fine. > > And I guess somebody will scream if it bites them ;) > > Anyway, my gut feel is that this is potentially a real problem, and we > should fix it asap (ie it should go into 2.6.24 even at this late stage in > the game), but it would be nice to know if the problem actually hit any > actual real program, and not just a test-setup. Steve/David, where can I find the test case, please? > So here's a question for David Holmes: What caused you to actually notice > this behaviour? Can this actually be seen in real life usage? > > Anyway, at a minimum, here's an > > Acked-by: Linus Torvalds > > and I suspect I should just apply it directly. Any comments from anybody > else? --- ~Randy Features and documentation: http://lwn.net/Articles/260136/