From: David Miller <davem@davemloft.net>
To: macro@linux-mips.org
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] esp_scsi: Fix reset cleanup spinlock recursion
Date: Wed, 05 Dec 2007 21:12:51 -0800 (PST) [thread overview]
Message-ID: <20071205.211251.58003209.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64N.0712051529470.5943@blysk.ds.pg.gda.pl>
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Wed, 5 Dec 2007 16:10:54 +0000 (GMT)
> The esp_reset_cleanup() function is called with the host lock held and
> invokes starget_for_each_device() which wants to take it too. Here is a
> fix along the lines of shost_for_each_device()/__shost_for_each_device()
> adding a __starget_for_each_device() counterpart which assumes the lock
> has already been taken.
>
> Eventually, I think the driver should get modified so that more work is
> done as a softirq rather than in the interrupt context, but for now it
> fixes a bug that causes the spinlock debugger to fire.
>
> While at it, it fixes a small number of cosmetic problems with
> starget_for_each_device() too.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Acked-by: David S. Miller <davem@davemloft.net>
Thanks for finding and fixing this bug.
prev parent reply other threads:[~2007-12-06 5:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 16:10 Maciej W. Rozycki
2007-12-06 5:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205.211251.58003209.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®