Re: [PATCH] NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning

[Herbert Xu <herbert@gondor.apana.org.au>]

On Wed, Dec 05, 2007 at 02:30:10PM +0900, Joonwoo Park wrote:
>
> @@ -140,9 +147,11 @@ int dev_mc_sync(struct net_device *to, struct net_device *from)
>  		da = next;
>  	}
>  	if (!err)
> -		__dev_set_rx_mode(to);
> +		pending = __dev_set_rx_mode(to);
>  	netif_tx_unlock_bh(to);
>  
> +	if (pending)
> +		__dev_set_rx_mode_fini(to);

The idea is to not touch the unicast stuff at all on the multicast path.

Anyway, this was discussed on netdev so please check the archives because
there is more to this than just changing the multicast handling.  We also
talked about consolidating the driver interface so that all these calls
have the same environment rather than the mix-and-match that we have now.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt