From: npiggin@suse.de
To: akpm@linux-foundation.org
Cc: tiwai@suse.de, annabellesgarden@yahoo.de, linux-kernel@vger.kernel.org
Subject: [patch 15/18] alsa: usx2y nopage
Date: Wed, 05 Dec 2007 18:16:02 +1100 [thread overview]
Message-ID: <20071205071628.332985000@nick.local0.net> (raw)
In-Reply-To: <20071205071547.701344000@nick.local0.net>
[-- Attachment #1: alsa-usx2y-nopage.patch --]
[-- Type: text/plain, Size: 3222 bytes --]
Convert alsa usx2y driver from nopage to fault.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: tiwai@suse.de
Cc: annabellesgarden@yahoo.de
Cc: linux-kernel@vger.kernel.org
---
sound/usb/usx2y/usX2Yhwdep.c | 21 ++++++++-------------
sound/usb/usx2y/usx2yhwdeppcm.c | 19 ++++++-------------
2 files changed, 14 insertions(+), 26 deletions(-)
Index: linux-2.6/sound/usb/usx2y/usX2Yhwdep.c
===================================================================
--- linux-2.6.orig/sound/usb/usx2y/usX2Yhwdep.c
+++ linux-2.6/sound/usb/usx2y/usX2Yhwdep.c
@@ -34,34 +34,29 @@
int usX2Y_hwdep_pcm_new(struct snd_card *card);
-static struct page * snd_us428ctls_vm_nopage(struct vm_area_struct *area, unsigned long address, int *type)
+static int snd_us428ctls_vm_fault(struct vm_area_struct *area, struct vm_fault *vmf)
{
unsigned long offset;
struct page * page;
void *vaddr;
- snd_printdd("ENTER, start %lXh, ofs %lXh, pgoff %ld, addr %lXh\n",
+ snd_printdd("ENTER, start %lXh, pgoff %ld\n",
area->vm_start,
- address - area->vm_start,
- (address - area->vm_start) >> PAGE_SHIFT,
- address);
+ vmf->pgoff);
- offset = area->vm_pgoff << PAGE_SHIFT;
- offset += address - area->vm_start;
- snd_assert((offset % PAGE_SIZE) == 0, return NOPAGE_SIGBUS);
+ offset = vmf->pgoff << PAGE_SHIFT;
vaddr = (char*)((struct usX2Ydev *)area->vm_private_data)->us428ctls_sharedmem + offset;
page = virt_to_page(vaddr);
get_page(page);
- snd_printdd( "vaddr=%p made us428ctls_vm_nopage() return %p; offset=%lX\n", vaddr, page, offset);
+ vmf->page = page;
- if (type)
- *type = VM_FAULT_MINOR;
+ snd_printdd( "vaddr=%p made us428ctls_vm_fault() page %p\n", vaddr, page);
- return page;
+ return 0;
}
static struct vm_operations_struct us428ctls_vm_ops = {
- .nopage = snd_us428ctls_vm_nopage,
+ .fault = snd_us428ctls_vm_fault,
};
static int snd_us428ctls_mmap(struct snd_hwdep * hw, struct file *filp, struct vm_area_struct *area)
Index: linux-2.6/sound/usb/usx2y/usx2yhwdeppcm.c
===================================================================
--- linux-2.6.orig/sound/usb/usx2y/usx2yhwdeppcm.c
+++ linux-2.6/sound/usb/usx2y/usx2yhwdeppcm.c
@@ -683,30 +683,23 @@ static void snd_usX2Y_hwdep_pcm_vm_close
}
-static struct page * snd_usX2Y_hwdep_pcm_vm_nopage(struct vm_area_struct *area, unsigned long address, int *type)
+static int snd_usX2Y_hwdep_pcm_vm_fault(struct vm_area_struct *area, struct vm_fault *vmf)
{
unsigned long offset;
- struct page *page;
void *vaddr;
- offset = area->vm_pgoff << PAGE_SHIFT;
- offset += address - area->vm_start;
- snd_assert((offset % PAGE_SIZE) == 0, return NOPAGE_OOM);
+ offset = vmf->pgoff << PAGE_SHIFT;
vaddr = (char*)((struct usX2Ydev *)area->vm_private_data)->hwdep_pcm_shm + offset;
- page = virt_to_page(vaddr);
- get_page(page);
-
- if (type)
- *type = VM_FAULT_MINOR;
-
- return page;
+ vmf->page = virt_to_page(vaddr);
+ get_page(vmf->page);
+ return 0;
}
static struct vm_operations_struct snd_usX2Y_hwdep_pcm_vm_ops = {
.open = snd_usX2Y_hwdep_pcm_vm_open,
.close = snd_usX2Y_hwdep_pcm_vm_close,
- .nopage = snd_usX2Y_hwdep_pcm_vm_nopage,
+ .fault = snd_usX2Y_hwdep_pcm_vm_fault,
};
--
next prev parent reply other threads:[~2007-12-05 7:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 7:15 [patch 00/18] remove nopage npiggin
2007-12-05 7:15 ` [patch 01/18] ia64: ia32 nopage npiggin
2007-12-05 7:15 ` [patch 02/18] relay: nopage npiggin
2007-12-05 7:15 ` [patch 03/18] drm: nopage npiggin
2007-12-05 9:05 ` Dave Airlie
2007-12-05 9:17 ` Nick Piggin
2007-12-05 7:15 ` [patch 04/18] uio: nopage npiggin
2007-12-05 10:04 ` Hans-Jürgen Koch
2007-12-05 10:10 ` Nick Piggin
2007-12-05 10:25 ` Hans-Jürgen Koch
2007-12-05 10:37 ` Nick Piggin
2007-12-05 7:15 ` [patch 05/18] kvm: nopage npiggin
2007-12-05 10:40 ` Avi Kivity
2007-12-05 7:15 ` [patch 06/18] ieee1394: nopage npiggin
2007-12-05 13:09 ` Stefan Richter
2007-12-05 13:15 ` Stefan Richter
2007-12-05 23:52 ` Nick Piggin
2007-12-05 23:51 ` Nick Piggin
2007-12-15 13:04 ` Stefan Richter
2007-12-15 13:01 ` Stefan Richter
2007-12-05 7:15 ` [patch 07/18] v4l: nopage npiggin
2007-12-08 0:31 ` Andrew Morton
2007-12-08 9:15 ` Ingo Molnar
2007-12-08 10:15 ` Andrew Morton
2007-12-09 17:10 ` Randy Dunlap
2007-12-10 5:06 ` [patch] x64/page.h: convert some macros to inlines Randy Dunlap
2007-12-10 8:34 ` Ingo Molnar
2007-12-05 7:15 ` [patch 08/18] fb: defio nopage npiggin
2007-12-05 7:15 ` [patch 09/18] agp: alpha nopage npiggin
2007-12-05 7:15 ` [patch 10/18] sg: nopage npiggin
2008-02-08 3:45 ` Douglas Gilbert
2007-12-05 7:15 ` [patch 11/18] ib: nopage npiggin
2007-12-05 7:15 ` [patch 12/18] usb: mon nopage npiggin
2007-12-05 16:39 ` Pete Zaitcev
2007-12-05 23:54 ` Nick Piggin
2007-12-05 7:16 ` [patch 13/18] alsa: nopage npiggin
2007-12-13 15:35 ` Takashi Iwai
2007-12-05 7:16 ` [patch 14/18] oss: via nopage npiggin
2007-12-05 7:16 ` npiggin [this message]
2007-12-13 15:35 ` [patch 15/18] alsa: usx2y nopage Takashi Iwai
2007-12-05 7:16 ` [patch 16/18] mm: special mapping nopage npiggin
2007-12-05 7:16 ` [patch 17/18] mm: remove nopage npiggin
2007-12-05 22:47 ` Andrew Morton
2007-12-05 23:23 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205071628.332985000@nick.local0.net \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=annabellesgarden@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®