mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Holger Hoffstaette <holger@wizards.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	torvalds@linux-foundation.org
Subject: Re: Reproducible data corruption with sendfile+vsftp - splice regression?
Date: Thu, 6 Dec 2007 19:44:26 +0100	[thread overview]
Message-ID: <20071206184426.GA32599@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <pan.2007.12.06.09.28.08.913625@wizards.de>

Holger Hoffstaette <holger@wizards.de> :
[...]
> Maybe turning off sendfile or NAPI just lead to random success - so far it
> really looks like tso on the r8169 is the common cause.

TSO on the r8169 is the magic switch but the regression makes imvho more
sense from a VM pov:

- the corrupted file has the same size as the expected file
- the corrupted file exhibits holes which come as a multiple of 4096 bytes
  (8*4k, 2 places, there may be more)
- the r8169 driver does not know what a page is
- the 8169 hardware has a small 8192 bytes Tx buffer

It would be nice if someone could do a sendfile + vsftp test with TSO on a
different hardware. While I could not reproduce the corruption when simply
downloading a file that I had copied on the server with scp, it triggered
almost immediately after I copied it locally and tried to download the copy.

-- 
Ueimor

  reply	other threads:[~2007-12-06 18:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 23:42 Holger Hoffstaette
2007-11-30  8:07 ` Eric Dumazet
2007-11-30  9:20   ` Holger Hoffstaette
2007-11-30 10:39     ` Holger Hoffstaette
2007-11-30 18:26     ` Rick Jones
2007-12-02 16:00       ` Holger Hoffstaette
2007-12-02 20:49         ` Holger Hoffstaette
2007-12-05 22:54           ` Francois Romieu
2007-12-06  1:13             ` Francois Romieu
2007-12-06  9:28             ` Holger Hoffstaette
2007-12-06 18:44               ` Francois Romieu [this message]
2007-12-08 15:28                 ` Mark Lord
2007-12-13  2:19                 ` Holger Hoffstaette
2007-12-15 10:24                   ` Holger Hoffstaette
2007-12-15 13:43                 ` Holger Hoffstaette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071206184426.GA32599@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=holger@wizards.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®