From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbXLGIT5 (ORCPT ); Fri, 7 Dec 2007 03:19:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750986AbXLGITn (ORCPT ); Fri, 7 Dec 2007 03:19:43 -0500 Received: from mtagate7.uk.ibm.com ([195.212.29.140]:43670 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbXLGITl (ORCPT ); Fri, 7 Dec 2007 03:19:41 -0500 Date: Fri, 7 Dec 2007 09:19:24 +0100 From: Heiko Carstens To: Denis Cheng Cc: linux-s390@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/20] drivers/s390/: use LIST_HEAD instead of LIST_HEAD_INIT Message-ID: <20071207081924.GB8081@osiris.boeblingen.de.ibm.com> References: <1196954381-5483-1-git-send-email-crquan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1196954381-5483-1-git-send-email-crquan@gmail.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2007 at 11:19:41PM +0800, Denis Cheng wrote: > single list_head variable initialized with LIST_HEAD_INIT could almost > always can be replaced with LIST_HEAD declaration, this shrinks the code > and looks better. > > Signed-off-by: Denis Cheng > --- > drivers/s390/block/dcssblk.c | 2 +- > drivers/s390/char/raw3270.c | 4 ++-- > drivers/s390/char/tape_core.c | 2 +- > drivers/s390/net/netiucv.c | 3 +-- > drivers/s390/net/smsgiucv.c | 2 +- > 5 files changed, 6 insertions(+), 7 deletions(-) Thanks, applied. I added the possible change in arch/s390/mm/extmem.c to your patch.