From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481AbXLGQEZ (ORCPT ); Fri, 7 Dec 2007 11:04:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752105AbXLGQEQ (ORCPT ); Fri, 7 Dec 2007 11:04:16 -0500 Received: from pasmtpb.tele.dk ([80.160.77.98]:35693 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbXLGQEP (ORCPT ); Fri, 7 Dec 2007 11:04:15 -0500 Date: Fri, 7 Dec 2007 17:06:03 +0100 From: Sam Ravnborg To: Tejun Heo Cc: Linux Kernel , linux-scsi , James Bottomley Subject: Re: [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m Message-ID: <20071207160603.GB31641@uranus.ravnborg.org> References: <47594C57.4070006@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47594C57.4070006@gmail.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 07, 2007 at 10:36:23PM +0900, Tejun Heo wrote: > subdir-y|m isn't supposed to contain modules or built-in components. > Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA). > > Signed-off-by: Tejun Heo > Cc: Sam Ravnborg > Cc: James Bottomley Ack-by: Sam Ravnborg > --- > drivers/scsi/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile > index 2e6129f..72c8d2e 100644 > --- a/drivers/scsi/Makefile > +++ b/drivers/scsi/Makefile > @@ -18,7 +18,7 @@ CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF > CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS > CFLAGS_seagate.o = -DARBITRATE -DPARITY -DSEAGATE_USE_ASM > > -subdir-$(CONFIG_PCMCIA) += pcmcia > +obj-$(CONFIG_PCMCIA) += pcmcia/ > > obj-$(CONFIG_SCSI) += scsi_mod.o > obj-$(CONFIG_SCSI_TGT) += scsi_tgt.o