Re: 2.6.24-rc4-mm1: acpi reboots machine... solved

[Bjorn Helgaas <bjorn.helgaas@hp.com>]

On Tuesday 11 December 2007 10:44:43 am Borislav Petkov wrote:
> On Sun, Dec 09, 2007 at 10:19:47AM +0100, Borislav Petkov wrote:
> > On Sun, Dec 09, 2007 at 08:50:02AM +0100, Borislav Petkov wrote:
> > > Hi Andrew,
> > > Hi Len,
> > > 
> > > after booting 2.6.24-rc4-mm1 (2.6.24-rc4-190-g94545ba, otoh, boots just
> > > fine) on my asus laptop, the machine reboots after claiming that
> > > "Critical temperature reached (255 C)." However, the degrees number
> > > is kinda hinting at 0xff all-ones field. Will try dump_stack in
> > > acpi_thermal_critical() to checkout the call path. For now here's the netconsole bootlog:
> > 
> > Here's what i got so far:
> > 
> > [   50.287939] Pid: 1, comm: swapper Not tainted 2.6.24-rc4-mm1 #14
> > [   50.287999]  [<c0104b65>] show_trace_log_lvl+0x12/0x25
> > [   50.288103]  [<c01053e7>] show_trace+0xd/0x10
> > [   50.288202]  [<c0105a6c>] dump_stack+0x57/0x5f
> > [   50.288303]  [<c021c991>] acpi_thermal_check+0x150/0x3bb
> > [   50.288415]  [<c021d4b3>] acpi_thermal_add+0x261/0x2cf
> > [   50.288515]  [<c0213549>] acpi_device_probe+0x3e/0xdb
> > [   50.288615]  [<c023f8f5>] driver_probe_device+0xaf/0x12a
> > [   50.288717]  [<c023fa88>] __driver_attach+0x6c/0xa5
> > [   50.288817]  [<c023ee5a>] bus_for_each_dev+0x3e/0x60
> > [   50.288916]  [<c023f77d>] driver_attach+0x14/0x16
> > [   50.289015]  [<c023f5a6>] bus_add_driver+0xa6/0x1a8
> > [   50.289114]  [<c023fc53>] driver_register+0x42/0x47
> > [   50.289214]  [<c02138c2>] acpi_bus_register_driver+0x3a/0x3c
> > [   50.289316]  [<c044306b>] acpi_thermal_init+0x57/0x76
> > [   50.289424]  [<c04344a7>] kernel_init+0x138/0x280
> > [   50.289525]  [<c01047df>] kernel_thread_helper+0x7/0x10
> > [   50.289625]  =======================
> > [   50.289680] ACPI: Critical trip point
> > [   50.289736] Critical temperature reached (255 C), shutting down.
> > 
> > so in acpi_thermal_get_temperature() called in acpi_thermal_add() the
> > tz->temperature thingy is not set properly (printk's added):
> > 
> > [   50.276607] Old temp: 4294967023
> > [   50.281890] Got temp: 255
> > [   50.282567] Old temp: 255
> > [   50.287882] Got temp: 255
> > 
> > What's also strange is that the tz acpi_thermal is alloc'd with kzalloc and
> > there's still garbage in it after reading it in acpi_thermal_get_temperature()
> > for the first time. Debugging continues...
> 
> (i almost suspected that the problem might be something completely different.)
> well, after bisecting the rc4-mm1 tree for a whole day today, the evildoer
> turned out to be
> 
> broken-out/pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch.
> 
> After backing this one out, mm1 boots just fine here.

Thanks for tracking this down.  I'll look into your logs and see if I
can figure out what's going on.  There's another report related to that
patch here: http://lkml.org/lkml/2007/11/22/110 .  Looks like a different
symptom though, so probably a different fix.

Bjorn