From: Andrew Morton <akpm@linux-foundation.org>
To: "Marcin __lusarz" <marcin.slusarz@gmail.com>
Cc: linux-kernel@vger.kernel.org, adaplas@gmail.com
Subject: Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol
Date: Tue, 11 Dec 2007 16:57:00 -0800 [thread overview]
Message-ID: <20071211165700.fb20c939.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071209213429.GE9440@joi>
On Sun, 9 Dec 2007 22:34:33 +0100
Marcin __lusarz <marcin.slusarz@gmail.com> wrote:
> fbcon: fix sparse warning about shadowing 'p' symbol
>
Please always quote error messages and warnings in the changelog when
fixing them, thanks.
> ---
> drivers/video/console/fbcon.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index 0f32f4a..849e114 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, int lines)
> {
> struct fb_info *info = registered_fb[con2fb_map[fg_console]];
> struct fbcon_ops *ops = info->fbcon_par;
> - struct display *p = &fb_display[fg_console];
> + struct display *disp = &fb_display[fg_console];
We have a global symbol called "p"? That would be bad. Where is it?
(The patch is good anwyay - "p" is a poorly chosen identifier here).
next prev parent reply other threads:[~2007-12-12 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:34 Marcin Ślusarz
2007-12-12 0:57 ` Andrew Morton [this message]
2007-12-12 2:50 ` Dave Jones
2007-12-12 19:37 ` Marcin Ślusarz
2007-12-12 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211165700.fb20c939.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome