From: David Miller <davem@davemloft.net>
To: jesse.brandeburg@intel.com
Cc: joonwpark81@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au,
auke-jan.h.kok@intel.com
Subject: Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.
Date: Wed, 12 Dec 2007 07:12:54 -0800 (PST) [thread overview]
Message-ID: <20071212.071254.180816076.davem@davemloft.net> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F5203FBAF94@orsmsx418.amr.corp.intel.com>
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Date: Tue, 11 Dec 2007 16:38:37 -0800
> @@ -3933,6 +3933,10 @@ quit_polling:
> e1000_set_itr(adapter);
> netif_rx_complete(poll_dev, napi);
> e1000_irq_enable(adapter);
> + if (work_done == weight)
> + return work_done - 1;
> + else
> + return work_done;
Don't do this.
If you processed "weight" worth of packets, return that
exact value and do not netif_rx_complete() and do not
re-enable interrupts.
That is the only correct fix.
prev parent reply other threads:[~2007-12-12 15:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 9:13 Joonwoo Park
2007-12-11 10:32 ` David Miller
2007-12-11 12:36 ` Herbert Xu
2007-12-11 12:41 ` David Miller
2007-12-11 12:57 ` Joonwoo Park
2007-12-11 23:12 ` Brandeburg, Jesse
2007-12-11 23:27 ` Joonwoo Park
2007-12-11 23:42 ` Stephen Hemminger
2007-12-16 21:35 ` David Miller
2007-12-12 0:12 ` Joonwoo Park
2007-12-12 0:38 ` Brandeburg, Jesse
2007-12-12 15:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212.071254.180816076.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=auke-jan.h.kok@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=joonwpark81@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®