From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757486AbXLMEnh@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757486AbXLMEnh (ORCPT <rfc822;w@1wt.eu>);
	Wed, 12 Dec 2007 23:43:37 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752677AbXLMEn1
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 12 Dec 2007 23:43:27 -0500
Received: from agminet01.oracle.com ([141.146.126.228]:37617 "EHLO
	agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751002AbXLMEn1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 12 Dec 2007 23:43:27 -0500
Date: Wed, 12 Dec 2007 20:42:46 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: lkml <linux-kernel@vger.kernel.org>, perex@perex.cz
Subject: Re: [PATCH] sound/ad1848: fix printk format
Message-Id: <20071212204246.2d1fce7a.randy.dunlap@oracle.com>
In-Reply-To: <s5hzly0lv5z.wl%tiwai@suse.de>
References: <20071029112010.1cecaefd.randy.dunlap@oracle.com>
	<s5hzly0lv5z.wl%tiwai@suse.de>
Organization: Oracle Linux Eng.
X-Mailer: Sylpheed 2.4.7 (GTK+ 2.8.10; x86_64-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Brightmail-Tracker: AAAAAQAAAAI=
X-Brightmail-Tracker: AAAAAQAAAAI=
X-Whitelist: TRUE
X-Whitelist: TRUE
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 Oct 2007 12:05:28 +0100 Takashi Iwai wrote:

> At Mon, 29 Oct 2007 11:20:10 -0700,
> Randy Dunlap wrote:
> > 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Fix printk format warning:
> > 
> > sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Thanks, but another fix was already in ALSA tree.
> 
> Jaroslav, please prepare for push again?  Some patches are really
> worth to be in 2.6.24.

Hi,
This is still needed, over 1 month later....


> Takashi
> 
> > ---
> >  sound/isa/ad1848/ad1848_lib.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2624-rc1g4-v1.orig/sound/isa/ad1848/ad1848_lib.c
> > +++ linux-2624-rc1g4-v1/sound/isa/ad1848/ad1848_lib.c
> > @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
> >  	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
> >  		udelay(100);
> >  
> > -	snd_printdd("(1) timeout = %d\n", timeout);
> > +	snd_printdd("(1) timeout = %lu\n", timeout);
> >  
> >  #ifdef CONFIG_SND_DEBUG
> >  	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
> > -


---
~Randy