mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	Petr Tesarik <ptesarik@suse.cz>,
	tony.luck@intel.com
Subject: Re: [PATCH] arch_ptrace_stop
Date: Wed, 12 Dec 2007 14:36:27 -0800 (PST)	[thread overview]
Message-ID: <20071212223627.DDF1726F8D9@magilla.localdomain> (raw)
In-Reply-To: Andrew Morton's message of  Tuesday, 11 December 2007 21:51:35 -0800 <20071211215135.95ae3f6d.akpm@linux-foundation.org>

> Mutter.  These would be better as static inlines.  A macro just invites
> variable-unused warnings on non-ia64 and outright compilation errors on
> ia64.  Speaking from experience...
> 
> static inline void arch_ptrace_stop(int exit_code, siginfo_t *info)
> {
> }
> #define arch_ptrace_stop arch_ptrace_stop
> 
> should work?

That's fine with me.  I just followed the example of e.g. arch_ptrace_attach.

> >  /*
> > + * Return nonzero if there is a SIGKILL that should be waking us up.
> > + * Called with the siglock held.
> > + */
> > +static int sigkill_pending(struct task_struct *tsk)
> > +{
> > +	return ((sigismember(&tsk->pending.signal, SIGKILL) ||
> > +		 sigismember(&tsk->signal->shared_pending.signal, SIGKILL)) &&
> > +		!unlikely(sigismember(&tsk->blocked, SIGKILL)));
> > +}
> 
> Could you please take a peek at the infrastructure added by
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/add-lock_page_killable.patch
> and see if there is exploitable commonality?

I haven't reviewed that whole set in detail yet.  So I'd rather leave this
for a later cleanup.  (This ptrace change alone, along with its ia64
pieces, can probably go in much earlier without disrupting anything else.)

The fatal_signal_pending function in that patch is not exactly the same as
this check, though it might turn out that it's actually equivalent due to
higher-level constraints.  


Thanks,
Roland

  reply	other threads:[~2007-12-12 22:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1196959793.6586.3.camel@elijah.suse.cz>
2007-12-08  1:11 ` Roland McGrath
2007-12-12  5:51   ` Andrew Morton
2007-12-12 22:36     ` Roland McGrath [this message]
2007-12-13 17:29 Oleg Nesterov
2007-12-13 17:31 ` Matthew Wilcox
2007-12-13 17:39   ` Oleg Nesterov
2007-12-13 22:42 ` Roland McGrath
2007-12-16 16:24   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071212223627.DDF1726F8D9@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptesarik@suse.cz \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®