From: David Miller <davem@davemloft.net>
To: tcallawa@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compiler warning noise with FORE200E driver
Date: Thu, 13 Dec 2007 09:34:07 -0800 (PST) [thread overview]
Message-ID: <20071213.093407.42002244.davem@davemloft.net> (raw)
In-Reply-To: <1197562900.17945.16.camel@localhost.localdomain>
From: "Tom \"spot\" Callaway" <tcallawa@redhat.com>
Date: Thu, 13 Dec 2007 11:21:40 -0500
> gcc throws these warnings with:
>
> CONFIG_ATM_FORE200E=m
> # CONFIG_ATM_FORE200E_PCA is not set
>
> drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but
> not used
> drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined
> but not used
>
> By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions,
> the compiler warnings are silenced.
>
> (btw, I'm not subscribed to lkml, so please CC me on any responses,
> although this is a wholly trivial patch, so I'm not expecting any.)
>
> Signed-off-by: Tom "spot" Callaway <tcallawa@redhat.com>
Applied, thanks Tom.
prev parent reply other threads:[~2007-12-13 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 16:21 Tom "spot" Callaway
2007-12-13 17:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213.093407.42002244.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tcallawa@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome