* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Unify common definitions in page*.h.  To simplify other code, I added 
> typedefs for the value of pte/pmd/pud/pgd values, so they can be used 
> symbolically elsewhere without needing to have lots of 32/64/PAE 
> tests.
> 
> Also, add PAGETABLE_LEVELS define so that other definitions can test 
> for it directly rather than using indirect 32/64/PAE tests.
> 
> Signed-off-by: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>

hm, your patches dont build. This is the error i get:

 include/asm-generic/pgtable-nopmd.h:46:1: warning: this is the location of the previous definition
 In file included from include/asm/pgtable_32.h:86,
                 from include/asm/pgtable.h:131,
                 from include/linux/mm.h:39,
                 from include/linux/suspend.h:12,
                 from arch/x86/kernel/asm-offsets_32.c:12,
                 from arch/x86/kernel/asm-offsets.c:3:
 include/asm/pgtable-2level.h:55: error: redefinition of 'native_pte_clear'
 include/asm/pgtable-2level.h:43: error: previous definition of 'native_pte_clear' was here

config attached.

	Ingo