From: David Miller <davem@davemloft.net>
To: davidsen@tmr.com
Cc: herbert@gondor.apana.org.au, simon@fire.lp0.eu,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: sockets affected by IPsec always block (2.6.23)
Date: Sun, 16 Dec 2007 15:22:35 -0800 (PST) [thread overview]
Message-ID: <20071216.152235.213233734.davem@davemloft.net> (raw)
In-Reply-To: <4765AAFC.3040406@tmr.com>
From: Bill Davidsen <davidsen@tmr.com>
Date: Sun, 16 Dec 2007 17:47:24 -0500
> David Miller wrote:
> > From: Herbert Xu <herbert@gondor.apana.org.au>
> > Date: Wed, 5 Dec 2007 11:12:32 +1100
> >
> >> [INET]: Export non-blocking flags to proto connect call
> >>
> >> Previously we made connect(2) block on IPsec SA resolution. This is
> >> good in general but not desirable for non-blocking sockets.
> >>
> >> To fix this properly we'd need to implement the larval IPsec dst stuff
> >> that we talked about. For now let's just revert to the old behaviour
> >> on non-blocking sockets.
> >>
> >> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> > We made an explicit decision not to do things this way.
> >
> > Non-blocking has a meaning dependant upon the xfrm_larval_drop sysctl
> > setting, and this is across the board. If xfrm_larval_drop is zero,
> > non-blocking semantics do not extend to IPSEC route resolution,
> > otherwise it does.
> >
> > If he sets this sysctl to "1" as I detailed in my reply, he'll
> > get the behavior he wants.
> >
> I think you for the hint, but I would hardly call this sentence
> "detailed" in terms of being a cookbook solution to the problem.
I guess "echo '1' >/proc/sys/net/core/xfrm_larval_drop" is not
explicit enough? What more would you like me to say?
next prev parent reply other threads:[~2007-12-16 23:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 18:53 Simon Arlott
2007-12-05 0:12 ` Herbert Xu
2007-12-05 6:30 ` David Miller
2007-12-05 6:51 ` Herbert Xu
2007-12-05 7:12 ` David Miller
2007-12-05 7:16 ` Herbert Xu
2007-12-05 7:34 ` David Miller
2007-12-05 7:39 ` Herbert Xu
2007-12-05 9:55 ` David Miller
2007-12-05 9:57 ` Herbert Xu
2007-12-05 18:42 ` Stefan Rompf
2007-12-05 18:39 ` Stefan Rompf
2007-12-06 2:25 ` David Miller
2007-12-06 8:49 ` Stefan Rompf
2007-12-06 8:53 ` David Miller
2007-12-06 10:56 ` Stefan Rompf
2007-12-06 11:13 ` David Miller
2007-12-06 11:35 ` Stefan Rompf
2007-12-06 11:39 ` David Miller
2007-12-06 12:30 ` Stefan Rompf
2007-12-06 13:55 ` David Miller
2007-12-06 14:31 ` Stefan Rompf
2007-12-07 3:20 ` David Miller
2007-12-07 9:29 ` Stefan Rompf
2007-12-16 22:47 ` Bill Davidsen
2007-12-16 23:22 ` David Miller [this message]
2007-12-05 6:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216.152235.213233734.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davidsen@tmr.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome