From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] SUNRPC: make new svc_create_kthread function
Date: Tue, 18 Dec 2007 17:10:39 +0000 [thread overview]
Message-ID: <20071218171039.GA5908@infradead.org> (raw)
In-Reply-To: <1197996159-20799-4-git-send-email-jlayton@redhat.com>
> +int
> +svc_create_kthread(svc_thread_fn func, struct svc_rqst *rqstp)
> +{
> + struct svc_serv *serv = rqstp->rq_server;
> + struct task_struct *task;
> +
> + task = kthread_create((int (*)(void *)) func, rqstp, serv->sv_name);
> + if (IS_ERR(task))
> + return PTR_ERR(task);
> +
> + if (serv->sv_nrpools > 1)
> + svc_pool_map_set_cpumask(task, rqstp->rq_pool->sp_id, NULL);
> +
> + svc_sock_update_bufs(serv);
> + wake_up_process(task);
> + return 0;
I don't think we'll need this helper at all. For the normal case of
not using a pool the caller can just call svc_sock_update_bufs even
before creating the thread, and the just use kthread_run. That'll also
get rid of all this horrible casting things around for the thread entry
point function pointer.
prev parent reply other threads:[~2007-12-18 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 16:42 [PATCH 0/7] Intro: convert lockd to kthread and fix use-after-free (try #2) Jeff Layton
2007-12-18 16:42 ` [PATCH 1/7] SUNRPC: Allow svc_pool_map_set_cpumask to work with any task Jeff Layton
2007-12-18 16:42 ` [PATCH 2/7] SUNRPC: spin svc_rqst initialization to its own function Jeff Layton
2007-12-18 16:42 ` [PATCH 3/7] SUNRPC: make new svc_create_kthread function Jeff Layton
2007-12-18 16:42 ` [PATCH 4/7] NLM: Initialize completion variable in lockd_up Jeff Layton
2007-12-18 16:42 ` [PATCH 5/7] NLM: Have lockd call try_to_freeze Jeff Layton
2007-12-18 16:42 ` [PATCH 6/7] NLM: Convert lockd to use kthreads Jeff Layton
2007-12-18 16:42 ` [PATCH 7/7] NLM: Add reference counting to lockd Jeff Layton
2007-12-18 17:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218171039.GA5908@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome