mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Inline local_bh_disable when TRACE_IRQFLAGS
Date: Wed, 19 Dec 2007 11:40:33 +0800	[thread overview]
Message-ID: <20071219034033.GA5770@gondor.apana.org.au> (raw)

Hi Ingo:

I noticed that local_bh_disable is now always out-of-line.  The
change was made when TRACE_IRQFLAGS was added.  However, with
TRACE_IRQFLAGS off, local_bh_disable does exactly the same work
as before.  In particular, it does pretty much the same as what
preempt_disable does and the latter is always inline.

So I'm wondering if it would be reasonable to make it out-of-line
when TRACE_IRQFLAGS is off.  This may make a difference because
the networking stack is a frequent user of local_bh_disable and
local_bh_enable.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

             reply	other threads:[~2007-12-19  3:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19  3:40 Herbert Xu [this message]
2007-12-19 11:31 ` Ingo Molnar
2007-12-19 11:50   ` Herbert Xu
2007-12-19 14:03     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071219034033.GA5770@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®