mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Parag Warudkar <parag.warudkar@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, ak@suse.de,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Fix dmi_alloc() to not advance alloc index in case of failure
Date: Wed, 19 Dec 2007 11:50:36 +0100	[thread overview]
Message-ID: <20071219105036.GJ3521@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0712181937560.3616@mini.warudkars.net>


* Parag Warudkar <parag.warudkar@gmail.com> wrote:

> dmi_alloc() for CONFIG_X86_64 is defined to allocate from a static 
> array and it maintains a allocation index which is advanced each time 
> allocation is attempted - it gets incremented even if an allocation 
> fails thereby depriving any future request that may be small enough to 
> be satisfied from the array.
>
> Fix this by first testing if allocation is going to be possible and 
> incrementing alloc index only then.

Thanks, applied. Nice catch!

	Ingo

      reply	other threads:[~2007-12-19 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19  0:45 Parag Warudkar
2007-12-19 10:50 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071219105036.GJ3521@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parag.warudkar@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®