mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Voluntary leave_mm before entering ACPI C3
Date: Wed, 19 Dec 2007 21:54:32 +0100	[thread overview]
Message-ID: <20071219205431.GA8370@elte.hu> (raw)
In-Reply-To: <20071219193255.GA2158@elte.hu>


FYI, your patch needed the fix below for !SMP. It works fine otherwise.

	Ingo

---
 include/asm-x86/mmu.h |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux/include/asm-x86/mmu.h
===================================================================
--- linux.orig/include/asm-x86/mmu.h
+++ linux/include/asm-x86/mmu.h
@@ -20,6 +20,12 @@ typedef struct { 
 	void *vdso;
 } mm_context_t;
 
+#ifdef CONFIG_SMP
 void leave_mm(int cpu);
+#else
+static inline void leave_mm(int cpu)
+{
+}
+#endif
 
 #endif /* _ASM_X86_MMU_H */

  parent reply	other threads:[~2007-12-19 20:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19 18:34 Venki Pallipadi
2007-12-19 19:32 ` Ingo Molnar
2007-12-19 19:36   ` H. Peter Anvin
2007-12-19 19:40     ` Ingo Molnar
2007-12-19 19:48       ` H. Peter Anvin
2007-12-19 20:23         ` Venki Pallipadi
2007-12-20  7:53         ` Arjan van de Ven
2007-12-20 16:16           ` H. Peter Anvin
2007-12-20 18:22             ` Arjan van de Ven
2007-12-20 18:32               ` H. Peter Anvin
2007-12-20 19:28             ` Len Brown
2007-12-19 19:56       ` Venki Pallipadi
2007-12-19 20:54   ` Ingo Molnar [this message]
2007-12-20  2:08   ` Venki Pallipadi
2007-12-20  9:31     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071219205431.GA8370@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®