* Ingo Molnar wrote: > > Here's another round of the pagetable unification patches. I've > > done a few dozen rounds of randconfig builds on both 32- and 64-bit, > > so I hope that will prevent compile problems in your test > > environment. > > > > I've also boot-tested 64-bit and 32-bit PAE/non-PAE configs (both > > paravirt and non-paravirt). > > i've done a dozen random tests too and it's looking good so far. Nice > work! found a couple of bugs. firstly, 64-bit wasnt so lucky, you broke iounmap()/change_page_attr() :-) The crash is here: [ 0.000000] PCI: Calling quirk ffffffff804625d0 for 0000:00:02.0 [ 0.000000] PCI: Calling quirk ffffffff80565b10 for 0000:00:02.0 [ 0.000000] ------------[ cut here ]------------ [ 0.000000] kernel BUG at arch/x86/mm/pageattr_64.c:176! [ 0.000000] invalid opcode: 0000 [1] SMP [ 0.000000] CPU 1 [ 0.000000] Modules linked in: [ 0.000000] Pid: 1, comm: swapper Not tainted 2.6.24-rc5 #5 [ 0.000000] RIP: 0010:[] [] __change_page_attr+0x189/0x2e0 [ 0.000000] RSP: 0018:ffff81003f9c3d30 EFLAGS: 00010282 [ 0.000000] RAX: 0000000000000400 RBX: 00000000000da103 RCX: ffffe20000000370 [ 0.000000] RDX: 000000000000006e RSI: 00003ffffffff000 RDI: ffff81000000a000 [ 0.000000] RBP: ffff81003f9c3d90 R08: 80000000da0001e3 R09: 0000000000000001 [ 0.000000] R10: 0000000000000001 R11: 00000000ffffffff R12: ffff81000000a680 [ 0.000000] R13: 0000000000000001 R14: 8000000000000163 R15: ffff8100da103000 [ 0.000000] FS: 0000000000000000(0000) GS:ffff81003f8014b0(0000) knlGS:0000000000000000 [ 0.000000] CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b [ 0.000000] CR2: 0000000000000000 CR3: 0000000000201000 CR4: 00000000000006e0 [ 0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 0.000000] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 0.000000] Process swapper (pid: 1, threadinfo ffff81003f9c2000, task ffff81003f9c0000) [ 0.000000] Stack: ffff8100da102000 8000000000000163 8000000000000163 0000000000000000 [ 0.000000] ffffffff809320e0 ffff8100da102000 ffff81003f9c3d70 00000000000da103 [ 0.000000] ffff8100da103000 0000000000000001 8000000000000163 0000000000000000 [ 0.000000] Call Trace: [ 0.000000] [] change_page_attr_addr+0xa6/0x150 [ 0.000000] [] ioremap_change_attr+0x5b/0x70 [ 0.000000] [] iounmap+0xbf/0xe0 [ 0.000000] [] quirk_usb_early_handoff+0x313/0x410 [ 0.000000] [] kobject_put+0x19/0x20 [ 0.000000] [] put_device+0x15/0x20 [ 0.000000] [] pci_fixup_device+0x8d/0xe0 [ 0.000000] [] pci_init+0x1d/0x40 [ 0.000000] [] kernel_init+0x164/0x350 [ 0.000000] [] trace_hardirqs_on+0xbf/0x160 [ 0.000000] [] trace_hardirqs_on_thunk+0x35/0x3a [ 0.000000] [] trace_hardirqs_on+0xbf/0x160 [ 0.000000] [] child_rip+0xa/0x12 [ 0.000000] [] restore_args+0x0/0x30 [ 0.000000] [] kernel_init+0x0/0x350 [ 0.000000] [] child_rip+0x0/0x12 [ 0.000000] [ 0.000000] [ 0.000000] Code: 0f 0b eb fe 0f 0b eb fe 0f 0b eb fe 0f 0b eb fe 48 b8 7f 0f [ 0.000000] RIP [] __change_page_attr+0x189/0x2e0 [ 0.000000] RSP [ 0.000000] Kernel panic - not syncing: Attempted to kill init! secondly, as i tried to bisect it, it would build and boot at this patch: Subject: x86: clean up asm-x86/page*.h but wouldnt build at this patch: Subject: x86: unify pgtable*.h nor at this patch: Subject: x86: fix up formatting in pgtable*.h it finally built at: Subject: x86: use a uniform structure for pte_t but crashed. So the bug is in one of those 3 patches. Please make them bisect-friendly. full bootlog and config attached. (The crash happens reliably here - if you cannot reproduce it then i can try any fix from you. I've removed the 5 patches of yours for now from x86.git.) Ingo