From: Ingo Oeser <ioe-lkml@rameria.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] add task handling notifier
Date: Thu, 20 Dec 2007 23:25:14 +0100 [thread overview]
Message-ID: <200712202325.14922.ioe-lkml@rameria.de> (raw)
In-Reply-To: <476A780C.76E4.0078.0@novell.com>
Hi Jan,
I like and support your idea!
On Thursday 20 December 2007, Jan Beulich wrote:
> With more and more sub-systems/sub-components leaving their footprint
> in task handling functions, it seems reasonable to add notifiers that
> these components can use instead of having them all patch themselves
> directly into core files.
Yes, but why export variables? Wouldn't it be better to export
an API?
That simplifies the callers (they all pass "current" as task
and "task_notifier_list" as arguments).
It also prevents exposing internal variables (notifier lists
ARE internal variables) to modules.
What do you think?
Best Regards
Ingo Oeser
next prev parent reply other threads:[~2007-12-20 22:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 13:11 Jan Beulich
2007-12-20 22:25 ` Ingo Oeser [this message]
2007-12-21 7:36 ` Jan Beulich
2007-12-23 12:26 ` Christoph Hellwig
2007-12-25 22:05 ` Andrew Morton
2008-01-08 13:38 ` Jan Beulich
2008-01-08 22:14 ` Andrew Morton
2008-01-09 0:03 ` Paul Jackson
2008-01-09 0:31 ` Andrew Morton
2008-01-09 2:47 ` Matt Helsley
2008-01-09 3:22 ` Andrew Morton
2008-01-09 9:52 ` Jan Beulich
2008-01-09 10:03 ` Christoph Hellwig
2008-01-09 2:24 ` Matt Helsley
2008-01-09 3:27 ` Matthew Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712202325.14922.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®