From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>
Cc: Michael Ellerman <michael@ellerman.id.au>,
linuxppc-dev@ozlabs.org, "Kyle A. Lucke" <klucke@us.ibm.com>,
paulus@samba.org, linux-kernel@vger.kernel.org,
David Gibson <dwg@au1.ibm.com>
Subject: Re: drivers/net/iseries_veth.c dubious sysfs usage
Date: Mon, 24 Dec 2007 13:52:08 +1100 [thread overview]
Message-ID: <20071224135208.2a29ffc0.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20071213070829.GA13764@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
Hi Greg,
On Wed, 12 Dec 2007 23:08:29 -0800 Greg KH <greg@kroah.com> wrote:
>
> Hm, ok, it's odd as you are the only driver in the whole tree doing
> something like this, but it seems semi-resonable, so I can't complain :)
>
> I'll fix the core up to allow you to do this, thanks for the
> explanation.
So if this "seems semi-reasonable", why was the result
gregkh-driver-driver-add-driver_add_kobj-for-looney-iseries_veth-driver
containing "Hopefully no one uses this function in the future and the
iseries_veth driver authors come to their senses so I can remove this
hack..." as part of its comment. If you expect respect, you need to
treat others the same way ...
If what the driver writers are doing is "looney" (in your opinion), then
please describe a better way of doing what they are trying to do.
Sometimes, if people have to abuse the infrastructure, it is possible that
the infrastructure is lacking?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-12-24 2:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 9:30 Greg KH
2007-12-05 11:10 ` Michael Ellerman
2007-12-05 21:41 ` Greg KH
2007-12-06 3:48 ` Michael Ellerman
2007-12-11 23:56 ` [PATCH] Introduce driver_create/remove_dir Stephen Rothwell
2007-12-12 0:40 ` Randy Dunlap
2007-12-12 2:36 ` Stephen Rothwell
2007-12-13 7:10 ` Greg KH
2007-12-13 7:08 ` drivers/net/iseries_veth.c dubious sysfs usage Greg KH
2007-12-24 2:52 ` Stephen Rothwell [this message]
2007-12-24 5:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071224135208.2a29ffc0.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dwg@au1.ibm.com \
--cc=greg@kroah.com \
--cc=klucke@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®