From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: julia@diku.dk
Cc: jes@sgi.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/38] arch/ia64/sn: Use time_before, time_before_eq, etc.
Date: Tue, 25 Dec 2007 00:25:53 +0900 (JST) [thread overview]
Message-ID: <20071225.002553.56248499.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712241518040.23999@ask.diku.dk>
In article <Pine.LNX.4.64.0712241518040.23999@ask.diku.dk> (at Mon, 24 Dec 2007 15:18:56 +0100 (CET)), Julia Lawall <julia@diku.dk> says:
> diff -r -u -p a/arch/ia64/sn/kernel/xpc_main.c b/arch/ia64/sn/kernel/xpc_main.c
> --- a/arch/ia64/sn/kernel/xpc_main.c 2007-11-12 10:35:56.000000000 +0100
> +++ b/arch/ia64/sn/kernel/xpc_main.c 2007-12-23 20:32:54.000000000 +0100
> @@ -230,7 +231,7 @@ xpc_hb_beater(unsigned long dummy)
> {
> xpc_vars->heartbeat++;
>
> - if (jiffies >= xpc_hb_check_timeout) {
> + if (time_before_eq(jiffies, xpc_hb_check_timeout)) {
> wake_up_interruptible(&xpc_act_IRQ_wq);
> }
>
time_after_eq()
> @@ -270,7 +271,7 @@ xpc_hb_checker(void *ignore)
>
>
> /* checking of remote heartbeats is skewed by IRQ handling */
> - if (jiffies >= xpc_hb_check_timeout) {
> + if (time_before_eq(jiffies, xpc_hb_check_timeout)) {
> dev_dbg(xpc_part, "checking remote heartbeats\n");
> xpc_check_remote_hb();
>
ditto.
> @@ -305,7 +306,7 @@ xpc_hb_checker(void *ignore)
> /* wait for IRQ or timeout */
> (void) wait_event_interruptible(xpc_act_IRQ_wq,
> (last_IRQ_count < atomic_read(&xpc_act_IRQ_rcvd) ||
> - jiffies >= xpc_hb_check_timeout ||
> + time_before_eq(jiffies, xpc_hb_check_timeout) ||
> (volatile int) xpc_exiting));
> }
>
ditto.
--yoshfuji
prev parent reply other threads:[~2007-12-24 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 14:18 Julia Lawall
2007-12-24 15:25 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225.002553.56248499.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=jes@sgi.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®