From: Dave Young <hidave.darkstar@gmail.com>
To: khali@linux-fr.org
Cc: linux-kernel@vger.kernel.org, i2c@lm-sensors.org
Subject: [PATCH 04/12] i2c : Use mutex instead of semaphore in driver core
Date: Sat, 29 Dec 2007 09:07:51 +0800 [thread overview]
Message-ID: <20071229010751.GE2883@darkstar.te-china.tietoenator.com> (raw)
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/i2c/i2c-core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff -upr linux/drivers/i2c/i2c-core.c linux.new/drivers/i2c/i2c-core.c
--- linux/drivers/i2c/i2c-core.c 2007-12-28 10:06:58.000000000 +0800
+++ linux.new/drivers/i2c/i2c-core.c 2007-12-28 10:08:58.000000000 +0800
@@ -33,8 +33,8 @@
#include <linux/platform_device.h>
#include <linux/mutex.h>
#include <linux/completion.h>
+#include <linux/mutex.h>
#include <asm/uaccess.h>
-#include <asm/semaphore.h>
#include "i2c-core.h"
@@ -597,12 +597,12 @@ int i2c_register_driver(struct module *o
if (driver->attach_adapter) {
struct i2c_adapter *adapter;
- down(&i2c_adapter_class.sem);
+ mutex_lock(&i2c_adapter_class.mutex);
list_for_each_entry(adapter, &i2c_adapter_class.devices,
dev.node) {
driver->attach_adapter(adapter);
}
- up(&i2c_adapter_class.sem);
+ mutex_unlock(&i2c_adapter_class.mutex);
}
mutex_unlock(&core_lock);
@@ -631,7 +631,7 @@ void i2c_del_driver(struct i2c_driver *d
* attached. If so, detach them to be able to kill the driver
* afterwards.
*/
- down(&i2c_adapter_class.sem);
+ mutex_lock(&i2c_adapter_class.mutex);
list_for_each_entry(adap, &i2c_adapter_class.devices, dev.node) {
if (driver->detach_adapter) {
if (driver->detach_adapter(adap)) {
@@ -656,7 +656,7 @@ void i2c_del_driver(struct i2c_driver *d
}
}
}
- up(&i2c_adapter_class.sem);
+ mutex_unlock(&i2c_adapter_class.mutex);
unregister:
driver_unregister(&driver->driver);
next reply other threads:[~2007-12-29 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 1:07 Dave Young [this message]
2007-12-29 11:49 ` Stefan Richter
2008-01-02 1:06 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071229010751.GE2883@darkstar.te-china.tietoenator.com \
--to=hidave.darkstar@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®