From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: eis@baty.hanse.de, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/x25: Add missing x25_neigh_put
Date: Tue, 01 Jan 2008 19:31:12 -0800 (PST) [thread overview]
Message-ID: <20080101.193112.20706369.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801012206090.19803@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Tue, 1 Jan 2008 22:07:04 +0100 (CET)
> The function x25_get_neigh increments a reference count. At the point of
> the second goto out, the result of calling x25_get_neigh is only stored in
> a local variable, and thus no one outside the function will be able to
> decrease the reference count. Thus, x25_neigh_put should be called before
> the return in this case.
Patch applied, thanks.
prev parent reply other threads:[~2008-01-02 3:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 21:07 Julia Lawall
2008-01-02 3:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101.193112.20706369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eis@baty.hanse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®