From: Andy Whitcroft <apw@shadowen.org>
To: Benny Halevy <bhalevy@panasas.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Joel Schopp <jschopp@austin.ibm.com>
Subject: Re: [PATCH] checkpatch.pl: recognize the #elif preprocessor directive
Date: Wed, 2 Jan 2008 09:49:56 +0000 [thread overview]
Message-ID: <20080102094956.GB23164@shadowen.org> (raw)
In-Reply-To: <477A1206.4070805@panasas.com>
On Tue, Jan 01, 2008 at 12:12:22PM +0200, Benny Halevy wrote:
> checkpatch.pl does not recognize #elif as a preprocessor directive
> causing it to print bogus errors for, e.g.:
> ERROR: need consistent spacing around '&' (ctx:WxV)
> when the operator is not recognized as unary in this context.
>
> for example:
>
> void foo(void)
> {
> int x, y, z;
> void *p[1] = {
> #if defined(X)
> &x
> #elif defined(Y)
> &y
> #else
> &z
> #endif
> };
> }
>
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Yes, thanks; good catch. Commited this and added tests for it.
Will be in 0.13 which is imminent.
-apw
prev parent reply other threads:[~2008-01-02 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 10:12 Benny Halevy
2008-01-02 9:49 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102094956.GB23164@shadowen.org \
--to=apw@shadowen.org \
--cc=bhalevy@panasas.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome