From: Erez Zadok <ezk@cs.sunysb.edu>
To: Joe Perches <joe@perches.com>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk,
hch@infradead.org
Subject: Re: [PATCH 1/3] Unionfs: use printk KERN_CONT for debugging messages
Date: Thu, 3 Jan 2008 13:36:06 -0500 [thread overview]
Message-ID: <200801031836.m03Ia6Cb024361@agora.fsl.cs.sunysb.edu> (raw)
In-Reply-To: Your message of "Wed, 02 Jan 2008 22:26:20 PST." <1199341581.6615.39.camel@localhost>
In message <1199341581.6615.39.camel@localhost>, Joe Perches writes:
> On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote:
> I think printks should be single statements and
> KERN_CONT should be used as sparingly as possible.
[...]
KERN_CONT is documented as not being SMP safe, but I figured it was harmless
for just some debugging message. Still, I like your way better. Thanks
Joe.
> Perhaps:
> pr_debug("IT(%lu:%d): %s:%s:%d "
> "um=%lu/%lu lm=%lu/%lu "
> "uc=%lu/%lu lc=%lu/%lu\n",
> inode->i_ino, bindex, file, fnx, line,
> inode->i_mtime.tv_sec, inode->i_mtime.tv_nsec,
> lower_inode->i_mtime.tv_sec,
> lower_inode->i_mtime.tv_nsec
> inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec,
> lower_inode->i_ctime.tv_sec,
> lower_inode->i_ctime.tv_nsec);
[...]
Erez.
next prev parent reply other threads:[~2008-01-03 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 5:57 [GIT PULL -mm] 0/3 Unionfs updates/fixes/cleanups Erez Zadok
2008-01-03 5:57 ` [PATCH 1/3] Unionfs: use printk KERN_CONT for debugging messages Erez Zadok
2008-01-03 6:26 ` Joe Perches
2008-01-03 18:36 ` Erez Zadok [this message]
2008-01-03 5:57 ` [PATCH 2/3] Unionfs: locking fixes Erez Zadok
2008-01-03 5:57 ` [PATCH 3/3] Unionfs: use VFS helpers to manipulate i_nlink Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801031836.m03Ia6Cb024361@agora.fsl.cs.sunysb.edu \
--to=ezk@cs.sunysb.edu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®