From: David Miller <davem@davemloft.net>
To: alan@lxorguk.ukuu.org.uk
Cc: matthias@goebl.net, linux-kernel@vger.kernel.org, kkeil@suse.de,
kai.germaschewski@gmx.de
Subject: Re: [PATCH] isdn/i4l: 'NO CARRIER' message lost after ldisc flush
Date: Fri, 04 Jan 2008 02:19:46 -0800 (PST) [thread overview]
Message-ID: <20080104.021946.100193287.davem@davemloft.net> (raw)
In-Reply-To: <20080103223054.2b51450b@lxorguk.ukuu.org.uk>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 3 Jan 2008 22:30:54 +0000
> > For non-audio connections the problem remains.
> > Maybe we can remove the tty_ldisc_flush() in isdn_tty_modem_result()
> > at all because it's done at tty_close?
>
> I'm not sure I understand why the tty_ldisc_flush is being done in the
> ISDN layer at this point but this change looks fine to me.
I'll apply this fix to net-2.6 and push to Linus.
Thanks.
prev parent reply other threads:[~2008-01-04 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 21:05 [PATCH] tty flush flip buffer on ldisc input queue flush Paul Fulghum
2008-01-03 22:00 ` [PATCH] isdn/i4l: 'NO CARRIER' message lost after ldisc flush Matthias Goebl
2008-01-03 22:30 ` Alan Cox
2008-01-04 10:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104.021946.100193287.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias@goebl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome