From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329AbYAFHPh (ORCPT ); Sun, 6 Jan 2008 02:15:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751718AbYAFHP0 (ORCPT ); Sun, 6 Jan 2008 02:15:26 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:52169 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750961AbYAFHPZ (ORCPT ); Sun, 6 Jan 2008 02:15:25 -0500 Date: Sat, 05 Jan 2008 23:15:24 -0800 (PST) Message-Id: <20080105.231524.204142940.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: viro@ZenIV.linux.org.uk, m.kozlowski@tuxland.pl, sparclinux@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: sparc oops in ip_fast_csum From: David Miller In-Reply-To: References: <20080105094400.GH27894@ZenIV.linux.org.uk> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Sun, 06 Jan 2008 11:22:04 +1100 > [IPV4] raw: Strengthen check on validity of iph->ihl > > We currently check that iph->ihl is bounded by the real length and that > the real length is greater than the minimum IP header length. However, > we did not check the caes where iph->ihl is less than the minimum IP > header length. > > This breaks because some ip_fast_csum implementations assume that which > is quite reasonable. > > Signed-off-by: Herbert Xu Applied, I'll push this to -stable too, thanks Herbert.