From: David Miller <davem@davemloft.net>
To: apw@us.ibm.com
Cc: horms@verge.net.au, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Fix regression in ip command line processing
Date: Sat, 05 Jan 2008 23:20:33 -0800 (PST) [thread overview]
Message-ID: <20080105.232033.240181112.davem@davemloft.net> (raw)
In-Reply-To: <20080106035816.GA16459@us.ibm.com>
From: Amos Waterland <apw@us.ibm.com>
Date: Sat, 5 Jan 2008 22:58:16 -0500
> ADDRESS ASSIGNED
>
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=on"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=dhcp"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=both"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=any"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=::::::on"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=::::::dhcp"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=10.0.2.15::10.0.2.2:255.255.255.0::eth0:off"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=10.0.2.15::10.0.2.2:255.255.255.0::eth0:on"
>
> ADDRESS NOT ASSIGNED
>
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip="
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=off"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=::::::off"
I really wish Simon had tested his original patch as extensively
as you have, this is the second major regression it has caused.
:-/
I'll apply your fix, although I'll break up some super long lines
you've added, thanks a lot.
next prev parent reply other threads:[~2008-01-06 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-26 2:59 [patch] ipv4: Update ip command line processing (take II) Simon Horman
2007-12-26 4:55 ` David Miller
2007-12-26 5:04 ` Simon Horman
2008-01-06 3:58 ` [PATCH] Fix regression in ip command line processing Amos Waterland
2008-01-06 7:20 ` David Miller [this message]
2008-01-06 9:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080105.232033.240181112.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=apw@us.ibm.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®