From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Miller <davem@davemloft.net>
Cc: lizf@cn.fujitsu.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback()
Date: Sat, 5 Jan 2008 18:24:49 +0300 [thread overview]
Message-ID: <20080105152449.GA12982@2ka.mipt.ru> (raw)
In-Reply-To: <20080104.015125.103222890.davem@davemloft.net>
Hi.
Sorry for long reply.
On Fri, Jan 04, 2008 at 01:51:25AM -0800, David Miller (davem@davemloft.net) wrote:
> > Error code should be set to EINVAL instead of ENODEV if !queue_work().
> > There's another call of queue_work() which may set err to EINVAL.
> >
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>
> This one is a bug fix so I'll apply it to net-2.6 and push
> to Linus.
>
> The rest are cleanups which I'll queue up for 2.6.25
Although I'm not sure changing error from nodev to inval is a bug fix :),
I have no problem with pushing it first.
Loop above will break out after first matched id, so it will never call
the path, which can change error, again.
Thanks a lot for patches and quick merge!
--
Evgeniy Polyakov
prev parent reply other threads:[~2008-01-05 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 5:53 Li Zefan
2008-01-04 9:51 ` David Miller
2008-01-05 15:24 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080105152449.GA12982@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®