From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758543AbYAFBEj (ORCPT ); Sat, 5 Jan 2008 20:04:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755754AbYAFBEP (ORCPT ); Sat, 5 Jan 2008 20:04:15 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:2964 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754146AbYAFBEN (ORCPT ); Sat, 5 Jan 2008 20:04:13 -0500 Date: Sun, 6 Jan 2008 12:03:59 +1100 From: Herbert Xu To: Jan Engelhardt Cc: Al Viro , m.kozlowski@tuxland.pl, davem@davemloft.net, sparclinux@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: sparc oops in ip_fast_csum Message-ID: <20080106010358.GA2991@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 06, 2008 at 01:57:13AM +0100, Jan Engelhardt wrote: > > >@@ -304,7 +305,8 @@ static int raw_send_hdrinc(struct sock *sk, void *from, size_t length, > > goto error_fault; > > > > /* We don't modify invalid header */ > >- if (length >= sizeof(*iph) && iph->ihl * 4U <= length) { > >+ iphlen = iph->ihl * 4; > >+ if (iphlen >= sizeof(*iph) && iphlen <= length) { > > Humm, this could use ip_hdrlen(skb) :-) That would not necessarily be an improvement since we'd have to reload the values from skb. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt