From: Ingo Oeser <ioe-lkml@rameria.de>
To: Bernd Schubert <bernd-schubert@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sleep before boot panic
Date: Sun, 6 Jan 2008 20:01:14 +0100 [thread overview]
Message-ID: <200801062001.15220.ioe-lkml@rameria.de> (raw)
In-Reply-To: <200801061908.43010.bernd-schubert@gmx.de>
Hi Bernd,
On Sunday 06 January 2008, you wrote:
> Index: zd1211rw.git.beno/init/do_mounts.c
> ===================================================================
> --- zd1211rw.git.beno.orig/init/do_mounts.c 2008-01-06 18:44:23.000000000
> +0100
> +++ zd1211rw.git.beno/init/do_mounts.c 2008-01-06 18:45:44.000000000 +0100
> @@ -330,6 +330,7 @@
> printk("Please append a correct \"root=\" boot option; here are the
> available partitions:\n");
>
> printk_all_partitions();
> + msleep(60 * 1000);
ssleep(60);
> panic("VFS: Unable to mount root fs on %s", b);
> }
Better would be for this and similiar panic()s
(fatal user/admin errors on boot) to NOT print a stack trace+registers,
since it is useless and actually hides useful information.
Best Regards
Ingo Oeser
next prev parent reply other threads:[~2008-01-06 19:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 18:08 Bernd Schubert
2008-01-06 19:01 ` Ingo Oeser [this message]
2008-01-06 19:23 ` Bernd Schubert
2008-01-06 20:38 ` Ingo Oeser
2008-01-07 20:41 ` Andi Kleen
2008-01-08 6:17 ` Ingo Oeser
2008-01-08 6:52 ` H. Peter Anvin
2008-01-08 16:06 ` Pavel Machek
2008-01-09 18:03 ` H. Peter Anvin
2008-01-10 19:20 ` kinit (was: sleep before boot panic) Ingo Oeser
2008-01-08 16:11 ` sleep before boot panic Andi Kleen
2008-01-15 9:38 ` Andrew Morton
[not found] <9II6K-1Pg-9@gated-at.bofh.it>
[not found] ` <9IJ2M-3l2-3@gated-at.bofh.it>
[not found] ` <9IJme-3Nb-13@gated-at.bofh.it>
[not found] ` <9IKrY-5vk-15@gated-at.bofh.it>
2008-01-07 11:47 ` Bodo Eggert
2008-01-07 15:03 ` Pavel Machek
2008-01-08 13:26 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801062001.15220.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=bernd-schubert@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®