From: David Miller <davem@davemloft.net>
To: Brice.Goglin@inria.fr
Cc: gallatin@myri.com, themann@de.ibm.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH][LRO] Fix lro_mgr->features checks
Date: Mon, 07 Jan 2008 22:09:28 -0800 (PST) [thread overview]
Message-ID: <20080107.220928.211341509.davem@davemloft.net> (raw)
In-Reply-To: <47822A2C.4020303@inria.fr>
From: Brice Goglin <Brice.Goglin@inria.fr>
Date: Mon, 07 Jan 2008 14:33:32 +0100
> [PATCH][LRO] Fix lro_mgr->features checks
>
> lro_mgr->features contains a bitmask of LRO_F_* values which are
> defined as power of two, not as bit indexes.
> They must be checked with x&LRO_F_FOO, not with test_bit(LRO_F_FOO,&x).
>
> Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
> Acked-by: Andrew Gallatin <gallatin@myri.com>
Applied, thanks a lot.
prev parent reply other threads:[~2008-01-08 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 13:33 Brice Goglin
2008-01-08 6:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107.220928.211341509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Brice.Goglin@inria.fr \
--cc=gallatin@myri.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=themann@de.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome