From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, tglx@tglx.de, hpa@zytor.com
Subject: Re: [patch 2/2] Use the stack frames to get exact stack-traces for CONFIG_FRAMEPOINTER on x86-64
Date: Tue, 8 Jan 2008 08:11:29 +0100 [thread overview]
Message-ID: <20080108071129.GB31838@elte.hu> (raw)
In-Reply-To: <20080107211437.5ba42f18@laptopd505.fenrus.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> x86 32 bit already has this feature: This patch uses the stack frames
> with frame pointer into an exact stack trace, by following the frame
> pointer. This only affects kernels built with the CONFIG_FRAME_POINTER
> config option enabled, and greatly reduces the amount of noise in
> oopses.
nice! Applied.
> The code tries to use the frame pointers to do a backtrace, but if it
> smells iffy or invalid, falls back to the traditional way of printing
> backtraces, to make sure that at least some useful backtrace is
> created.
>
> Due to the fragility and importance of the backtrace code, this needs
> to be well reviewed and well tested before merging into mainlne.
yeah, agreed. But i think this is still fundamentally more robust than
the unwind info based backtracer. Cool stuff!
Ingo
next prev parent reply other threads:[~2008-01-08 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 5:14 Arjan van de Ven
2008-01-08 7:11 ` Ingo Molnar [this message]
2008-01-08 17:01 ` Andi Kleen
2008-01-08 17:28 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108071129.GB31838@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@tglx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®