From: Rik van Riel <riel@redhat.com>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH 3/5] x86: coding style fixes in arch/x86/ia32/ia32_aout.c
Date: Tue, 8 Jan 2008 15:04:39 -0500 [thread overview]
Message-ID: <20080108150439.6388028e@bree.surriel.com> (raw)
In-Reply-To: <20080108203233.01bb5c7f@paolo-desktop>
On Tue, 8 Jan 2008 20:32:33 +0100
Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
> Fix plenty of coding style errors
Most of these kernel changes would probably get in the way of
real development, making patches reject that would otherwise
apply.
You did find one possible bug, though:
> @@ -467,9 +465,9 @@ static int load_aout_library(struct file *file)
>
> #ifdef WARN_OLD
> static unsigned long error_time;
> - if ((jiffies-error_time) > 5*HZ)
> - {
> - printk(KERN_WARNING
> + if ((jiffies-error_time) > 5*HZ) {
> +
> + printk(KERN_WARNING
> "N_TXTOFF is not page aligned. Please convert library: %s\n",
> file->f_path.dentry->d_name.name);
> error_time = jiffies;
You may want to look into the time_after() macro and make sure
it is used here.
--
All rights reversed.
next prev parent reply other threads:[~2008-01-08 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 19:32 Paolo Ciarrocchi
2008-01-08 19:59 ` Alexey Dobriyan
2008-01-08 20:04 ` Rik van Riel [this message]
2008-01-08 20:51 ` Sam Ravnborg
2008-01-08 21:52 ` Ingo Molnar
2008-01-08 22:17 ` Sam Ravnborg
2008-01-08 22:35 ` Ingo Molnar
2008-01-08 23:57 ` Sam Ravnborg
2008-01-09 0:15 ` Ingo Molnar
2008-01-08 22:55 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108150439.6388028e@bree.surriel.com \
--to=riel@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paolo.ciarrocchi@gmail.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome