mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH 4/4] Fixup container_of() usage
Date: Tue, 8 Jan 2008 21:40:51 +1100	[thread overview]
Message-ID: <200801082140.52018.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080108084629.GD6209@localhost.sw.ru>

On Tuesday 08 January 2008 19:46:29 Alexey Dobriyan wrote:
> Using "attr" twice is not OK, because it effectively prohibits such
> container_of() on variables not named "attr".
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

Thanks, nice catch.  Took me a while to understand that you meant "you can't 
use to_sq_sysfs_attr() on a variable not named attr".

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

      reply	other threads:[~2008-01-08 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  8:46 Alexey Dobriyan
2008-01-08 10:40 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801082140.52018.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=adobriyan@sw.ru \
    --cc=akpm@osdl.org \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome