From: Christoph Hellwig <hch@infradead.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Nikanth Karthikesan <knikanth@suse.de>,
grant@torque.net, tim@cyberelk.net,
Christoph Hellwig <hch@infradead.org>,
Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl
Date: Wed, 9 Jan 2008 12:20:28 +0000 [thread overview]
Message-ID: <20080109122027.GA13254@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0801091313231.29244@fbirervta.pbzchgretzou.qr>
On Wed, Jan 09, 2008 at 01:14:25PM +0100, Jan Engelhardt wrote:
> I wonder why a simple copy_from_user() requires the BKL.. if pt
> does need locking, then probably some mutex inside pt.
Given this is a janitorial project where the people don't even have
the hardware to test it's best to do a 1:1 conversion instead of making
it more complex.
next prev parent reply other threads:[~2008-01-09 12:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 6:14 Nikanth Karthikesan
2008-01-09 8:06 ` Christoph Hellwig
2008-01-09 8:23 ` Valdis.Kletnieks
[not found] ` <4784D3E0.BANGALORE.BLR.100.174746A.1.EABB.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10 8:55 ` Nikanth Karthikesan
2008-01-09 12:14 ` Jan Engelhardt
2008-01-09 12:20 ` Christoph Hellwig [this message]
2008-01-10 7:23 ` Nikanth Karthikesan
2008-01-09 12:33 ` Matthew Wilcox
2008-01-09 13:26 ` Jiri Kosina
2008-01-09 16:56 ` Alan Cox
2008-01-10 15:01 ` Jiri Kosina
2008-01-10 20:58 ` Alan Cox
[not found] ` <478681FE.BANGALORE.BLR.100.174746A.1.ECB1.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10 15:31 ` Nikanth Karthikesan
2008-01-10 15:50 ` Matthew Wilcox
[not found] ` <47854BF3.BANGALORE.BLR.100.174746A.1.EB89.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10 5:29 ` Nikanth Karthikesan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109122027.GA13254@infradead.org \
--to=hch@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=grant@torque.net \
--cc=jengelh@computergmbh.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome