From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754532AbYAIPtH (ORCPT ); Wed, 9 Jan 2008 10:49:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751260AbYAIPs4 (ORCPT ); Wed, 9 Jan 2008 10:48:56 -0500 Received: from one.firstfloor.org ([213.235.205.2]:33735 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbYAIPs4 (ORCPT ); Wed, 9 Jan 2008 10:48:56 -0500 Date: Wed, 9 Jan 2008 16:51:24 +0100 From: Andi Kleen To: Ingo Molnar Cc: Andi Kleen , tglx@linutronix.de, linux-kernel@vger.kernel.org, "H. Peter Anvin" Subject: Re: More breakage in native_rdtsc out of line in git-x86 Message-ID: <20080109155124.GB12923@one.firstfloor.org> References: <20080109035534.GA30321@basil.nowhere.org> <20080109090956.GA14274@elte.hu> <20080109141908.GB12855@one.firstfloor.org> <20080109152208.GA21280@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080109152208.GA21280@elte.hu> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2008 at 04:22:08PM +0100, Ingo Molnar wrote: > > * Andi Kleen wrote: > > > > nope, it's a 64-bit setup/dependency bug/problem: the vsyscall mappings > > > are installed via an __initcall, and that's too late for early use. The > > > combo patch below fixed the crash for me, does it work on your box too? > > > > That gives > > > > /home/lsrc/quilt/linux/arch/x86/kernel/setup_64.c: In function 'setup_arch': > > /home/lsrc/quilt/linux/arch/x86/kernel/setup_64.c:468: error: implicit declarati > > on of function 'map_vsyscall' > > i guess you have an old repository. I just applied the patch you sent out against yesterday's git-x86. > > > But after I add a prototype to vsyscall.h it seems to work. > > > > Just the barriers are still broken [...] > > since yesterday there's a full barrier around rdtsc. Great. -Andi