mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: vaf@cisco.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	yoshfuji@linux-ipv6.org, davem@davemloft.net
Subject: Re: [PATCH 001/001] ipv4: enable use of 240/4 address space
Date: Sat, 12 Jan 2008 14:47:29 +0900 (JST)	[thread overview]
Message-ID: <20080112.144729.67503025.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20080108011057.GA21168@cisco.com>

Hello.

In article <20080108011057.GA21168@cisco.com> (at Mon, 7 Jan 2008 17:10:57 -0800), Vince Fuller <vaf@cisco.com> says:

>  #define IN_MULTICAST_NET	0xF0000000
>  
> +#define IN_CLASSE(a)		((((long int) (a)) & 0xf0000000) == 0xf0000000)
> +#define	IN_CLASSE_NET		0xffffff00
> +#define	IN_CLASSE_NSHIFT	8
> +#define	IN_CLASSE_HOST		(0xffffffff & ~IN_CLASSE_NET)
> +
> +/* 
> + * these are no longer used
>  #define	IN_EXPERIMENTAL(a)	((((long int) (a)) & 0xf0000000) == 0xf0000000)
>  #define	IN_BADCLASS(a)		IN_EXPERIMENTAL((a))
> +*/

Please do not remove this, but have these instead:

#define IN_EXPERIMENTAL(a)	IN_CLASSE((a))
#define IN_BADCASS(a)		IN_CLASSE((a))

And, I think it is good to remove BADCLASS() (inside
#ifdef __KERNEL__ .. #endif) because we do not have its users
any longer, right?

Regards,

--yoshfuji

  parent reply	other threads:[~2008-01-12  5:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  1:10 Vince Fuller
2008-01-11  6:33 ` David Miller
2008-01-11 11:17 ` Andi Kleen
2008-01-11 12:41   ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-12  1:48     ` David Miller
2008-01-12  5:12       ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-11 17:29   ` Vince Fuller
2008-01-12  1:49     ` David Miller
2008-01-12 11:23       ` Jan Engelhardt
2008-01-12  5:47 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2008-01-17 23:04 ` Jan Engelhardt
2008-01-18  0:28   ` Vince Fuller
2008-01-18  1:13 ` [PATCH] IPv4: Enable " Jan Engelhardt
2008-01-18  1:26   ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-18  1:52     ` Jan Engelhardt
2008-01-18  2:13       ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-18  2:15         ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-19 13:44         ` Jan Engelhardt
2008-01-19 15:30           ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-21 11:19             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080112.144729.67503025.yoshfuji@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vaf@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®