From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Jon Smirl" <jonsmirl@gmail.com>
Cc: i2c@lm-sensors.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [i2c] [PATCH 19 1/5] Implement module aliasing for i2c to translate from device tree names
Date: Sat, 12 Jan 2008 14:47:22 +1100 [thread overview]
Message-ID: <20080112144722.e0de9306.sfr@canb.auug.org.au> (raw)
In-Reply-To: <9e4733910801111900w6ace7c3bxe7e5f781db07ae4b@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
Hi Jon,
On Fri, 11 Jan 2008 22:00:42 -0500 "Jon Smirl" <jonsmirl@gmail.com> wrote:
>
> +++ b/drivers/hwmon/f75375s.c
> @@ -117,7 +117,7 @@ struct f75375_data {
> static int f75375_attach_adapter(struct i2c_adapter *adapter);
> static int f75375_detect(struct i2c_adapter *adapter, int address, int kind);
> static int f75375_detach_client(struct i2c_client *client);
> -static int f75375_probe(struct i2c_client *client);
> +static int f75375_probe(struct i2c_client *client, const struct
> i2c_device_id *id);
Looks like your mail client has wrapped this. Also in various later
spots.
> +++ b/drivers/i2c/i2c-core.c
> @@ -47,6 +47,19 @@ static DEFINE_IDR(i2c_adapter_idr);
>
> /* ------------------------------------------------------------------------- */
>
> +static const struct i2c_device_id *i2c_match_id(
> + const struct i2c_device_id *id, struct i2c_client *client)
Any reason that the "client" argument is not const as well?
> +++ b/include/linux/i2c.h
> @@ -141,11 +141,10 @@ struct i2c_driver {
>
> struct device_driver driver;
> struct list_head list;
> + struct i2c_device_id *id_table;
Any reason that this is not const? Making it const would allow divers to
make their tables const.
These are just small things (apart from the wrapping) that can be fixed
up with followup patches.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-01-12 3:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 2:47 [PATCH 19 0/5] Version 18, series to add device tree naming to i2c Jon Smirl
2008-01-12 2:47 ` [PATCH 19 1/5] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2008-01-12 3:00 ` [i2c] " Jon Smirl
2008-01-12 3:47 ` Stephen Rothwell [this message]
2008-01-12 2:47 ` [PATCH 19 2/5] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2008-01-12 2:47 ` [PATCH 19 3/5] Clean up error returns Jon Smirl
2008-01-20 11:07 ` [i2c] " Jean Delvare
2008-01-20 15:18 ` Jon Smirl
2008-01-20 15:39 ` Jon Smirl
2008-01-21 16:10 ` Jean Delvare
2008-01-21 23:04 ` Benjamin Herrenschmidt
2008-01-21 23:06 ` Benjamin Herrenschmidt
2008-01-12 2:47 ` [PATCH 19 4/5] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2008-01-12 4:07 ` Stephen Rothwell
2008-01-12 2:47 ` [PATCH 19 5/5] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2008-04-10 9:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080112144722.e0de9306.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=i2c@lm-sensors.org \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®