From: Florian Fainelli <florian.fainelli@telecomint.eu>
To: Marc Pignat <marc.pignat@hevs.ch>
Cc: wim@iguana.be, linux-kernel@vger.kernel.org,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Mike Frysinger" <vapier.adi@gmail.com>
Subject: Re: [RFC, PATCH, take 2] watchdog on generic gpio
Date: Mon, 14 Jan 2008 12:06:38 +0100 [thread overview]
Message-ID: <200801141206.39858.florian.fainelli@telecomint.eu> (raw)
In-Reply-To: <200801141103.23744.marc.pignat@hevs.ch>
Hi Marc,
Le lundi 14 janvier 2008, Marc Pignat a écrit :
> +static int gpio_wdt_keepalive(struct gpio_wdt *wdt)
> +{
> + gpio_set_value(wdt->pdata->pin, 0);
> + gpio_set_value(wdt->pdata->pin, 1);
> + return 0;
> +}
I would like this function to be supplied by the platform_data structure
because as I mentioned before, not all GPIO connected watchdog will simply
need a single bit to be toggled, but also sometimes a full GPIO line.
If we do not supply any specific callback to keepalive the watchdog let's just
assume we need a single bit to be toggled if this is ok with you ?
Thank you !
--
Cordialement, Florian Fainelli
------------------------------
next prev parent reply other threads:[~2008-01-14 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 10:03 Marc Pignat
2008-01-14 11:06 ` Florian Fainelli [this message]
2008-01-14 13:01 ` Marc Pignat
2008-01-14 14:03 ` Florian Fainelli
2008-01-14 14:59 ` Marc Pignat
2008-01-14 15:57 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801141206.39858.florian.fainelli@telecomint.eu \
--to=florian.fainelli@telecomint.eu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.pignat@hevs.ch \
--cc=vapier.adi@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®