From: Andi Kleen <ak@suse.de>
To: linux-kernel@vger.kernel.org, jbeulich@novell.com, mingo@elte.hu,
tglx@linutronix.de
Subject: [PATCH] [8/31] CPA: Return the page table level in lookup_address()
Date: Mon, 14 Jan 2008 23:16:40 +0100 (CET) [thread overview]
Message-ID: <20080114221640.437A514F83@wotan.suse.de> (raw)
In-Reply-To: <200801141116.534682000@suse.de>
Needed for the next change.
And change all the callers.
Signed-off-by: Andi Kleen <ak@suse.de>
---
arch/x86/mm/fault_32.c | 3 ++-
arch/x86/mm/init_32.c | 3 ++-
arch/x86/mm/pageattr_32.c | 7 +++++--
arch/x86/mm/pageattr_64.c | 7 +++++--
arch/x86/xen/mmu.c | 9 ++++++---
include/asm-x86/pgtable_32.h | 2 +-
include/asm-x86/pgtable_64.h | 2 +-
7 files changed, 22 insertions(+), 11 deletions(-)
Index: linux/arch/x86/mm/pageattr_64.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr_64.c
+++ linux/arch/x86/mm/pageattr_64.c
@@ -13,7 +13,7 @@
#include <asm/tlbflush.h>
#include <asm/io.h>
-pte_t *lookup_address(unsigned long address)
+pte_t *lookup_address(unsigned long address, int *level)
{
pgd_t *pgd = pgd_offset_k(address);
pud_t *pud;
@@ -27,8 +27,10 @@ pte_t *lookup_address(unsigned long addr
pmd = pmd_offset(pud, address);
if (!pmd_present(*pmd))
return NULL;
+ *level = 3;
if (pmd_large(*pmd))
return (pte_t *)pmd;
+ *level = 4;
pte = pte_offset_kernel(pmd, address);
if (pte && !pte_present(*pte))
pte = NULL;
@@ -129,8 +131,9 @@ __change_page_attr(unsigned long address
pte_t *kpte;
struct page *kpte_page;
pgprot_t ref_prot2;
+ int level;
- kpte = lookup_address(address);
+ kpte = lookup_address(address, &level);
if (!kpte) return 0;
kpte_page = virt_to_page(((unsigned long)kpte) & PAGE_MASK);
BUG_ON(PageLRU(kpte_page));
Index: linux/include/asm-x86/pgtable_64.h
===================================================================
--- linux.orig/include/asm-x86/pgtable_64.h
+++ linux/include/asm-x86/pgtable_64.h
@@ -240,7 +240,7 @@ extern struct list_head pgd_list;
extern int kern_addr_valid(unsigned long addr);
-pte_t *lookup_address(unsigned long addr);
+pte_t *lookup_address(unsigned long addr, int *level);
#define io_remap_pfn_range(vma, vaddr, pfn, size, prot) \
remap_pfn_range(vma, vaddr, pfn, size, prot)
Index: linux/arch/x86/mm/pageattr_32.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr_32.c
+++ linux/arch/x86/mm/pageattr_32.c
@@ -18,7 +18,7 @@ static DEFINE_SPINLOCK(cpa_lock);
static struct list_head df_list = LIST_HEAD_INIT(df_list);
-pte_t *lookup_address(unsigned long address)
+pte_t *lookup_address(unsigned long address, int *level)
{
pgd_t *pgd = pgd_offset_k(address);
pud_t *pud;
@@ -31,8 +31,10 @@ pte_t *lookup_address(unsigned long addr
pmd = pmd_offset(pud, address);
if (pmd_none(*pmd))
return NULL;
+ *level = 2;
if (pmd_large(*pmd))
return (pte_t *)pmd;
+ *level = 3;
return pte_offset_kernel(pmd, address);
}
@@ -148,11 +150,12 @@ __change_page_attr(struct page *page, pg
pte_t *kpte;
unsigned long address;
struct page *kpte_page;
+ int level;
BUG_ON(PageHighMem(page));
address = (unsigned long)page_address(page);
- kpte = lookup_address(address);
+ kpte = lookup_address(address, &level);
if (!kpte)
return -EINVAL;
kpte_page = virt_to_page(kpte);
Index: linux/include/asm-x86/pgtable_32.h
===================================================================
--- linux.orig/include/asm-x86/pgtable_32.h
+++ linux/include/asm-x86/pgtable_32.h
@@ -182,7 +182,7 @@ static inline void clone_pgd_range(pgd_t
* NOTE: the return type is pte_t but if the pmd is PSE then we return it
* as a pte too.
*/
-extern pte_t *lookup_address(unsigned long address);
+extern pte_t *lookup_address(unsigned long address, int *level);
/*
* Make a given kernel text page executable/non-executable.
Index: linux/arch/x86/mm/fault_32.c
===================================================================
--- linux.orig/arch/x86/mm/fault_32.c
+++ linux/arch/x86/mm/fault_32.c
@@ -571,7 +571,8 @@ no_context:
#ifdef CONFIG_X86_PAE
if (error_code & PF_INSTR) {
- pte_t *pte = lookup_address(address);
+ int level;
+ pte_t *pte = lookup_address(address, &level);
if (pte && pte_present(*pte) && !pte_exec_kernel(*pte))
printk(KERN_CRIT "kernel tried to execute "
Index: linux/arch/x86/mm/init_32.c
===================================================================
--- linux.orig/arch/x86/mm/init_32.c
+++ linux/arch/x86/mm/init_32.c
@@ -529,11 +529,12 @@ int __init set_kernel_exec(unsigned long
{
pte_t *pte;
int ret = 1;
+ int level;
if (!nx_enabled)
goto out;
- pte = lookup_address(vaddr);
+ pte = lookup_address(vaddr, &level);
BUG_ON(!pte);
if (!pte_exec_kernel(*pte))
Index: linux/arch/x86/xen/mmu.c
===================================================================
--- linux.orig/arch/x86/xen/mmu.c
+++ linux/arch/x86/xen/mmu.c
@@ -58,7 +58,8 @@
xmaddr_t arbitrary_virt_to_machine(unsigned long address)
{
- pte_t *pte = lookup_address(address);
+ int level;
+ pte_t *pte = lookup_address(address, &level);
unsigned offset = address & PAGE_MASK;
BUG_ON(pte == NULL);
@@ -70,8 +71,9 @@ void make_lowmem_page_readonly(void *vad
{
pte_t *pte, ptev;
unsigned long address = (unsigned long)vaddr;
+ int level;
- pte = lookup_address(address);
+ pte = lookup_address(address, &level);
BUG_ON(pte == NULL);
ptev = pte_wrprotect(*pte);
@@ -84,8 +86,9 @@ void make_lowmem_page_readwrite(void *va
{
pte_t *pte, ptev;
unsigned long address = (unsigned long)vaddr;
+ int level;
- pte = lookup_address(address);
+ pte = lookup_address(address, &level);
BUG_ON(pte == NULL);
ptev = pte_mkwrite(*pte);
next prev parent reply other threads:[~2008-01-14 22:19 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 22:16 [PATCH] [0/31] Great change_page_attr patch series v2 Andi Kleen
2008-01-14 22:16 ` [PATCH] [1/31] Shrink __PAGE_KERNEL/__PAGE_KERNEL_EXEC on non PAE kernels Andi Kleen
2008-01-14 22:16 ` [PATCH] [2/31] CPA: Do a simple self test at boot Andi Kleen
2008-01-15 8:47 ` Harvey Harrison
2008-01-15 9:59 ` Andi Kleen
2008-01-15 10:07 ` Harvey Harrison
2008-01-14 22:16 ` [PATCH] [3/31] Add pte accessors for the global bit Andi Kleen
2008-01-14 22:16 ` [PATCH] [4/31] Add pte_pgprot on i386 Andi Kleen
2008-01-15 13:00 ` Johannes Weiner
2008-01-14 22:16 ` [PATCH] [5/31] Don't drop NX bit in pte modifier functions for 32bit Andi Kleen
2008-01-14 22:16 ` [PATCH] [6/31] CPA: Undo white space changes Andi Kleen
2008-01-14 22:16 ` [PATCH] [7/31] Extract page table dumping code from i386 fault handler into dump_pagetable() Andi Kleen
2008-01-15 8:56 ` Harvey Harrison
2008-01-15 10:00 ` Andi Kleen
2008-01-15 10:05 ` Harvey Harrison
2008-01-14 22:16 ` Andi Kleen [this message]
2008-01-14 22:16 ` [PATCH] [9/31] CPA: Add simple self test at boot Andi Kleen
2008-01-15 10:37 ` Harvey Harrison
2008-01-14 22:16 ` [PATCH] [10/31] CPA: Change kernel_map_pages to not use c_p_a() Andi Kleen
2008-01-14 22:16 ` [PATCH] [11/31] CPA: Change 32bit back to init_mm semaphore locking Andi Kleen
2008-01-14 22:16 ` [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr() Andi Kleen
2008-01-15 8:40 ` Jan Beulich
2008-01-15 9:57 ` Andi Kleen
2008-01-14 22:16 ` [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr Andi Kleen
2008-01-15 9:29 ` Harvey Harrison
2008-01-15 10:06 ` Andi Kleen
2008-01-15 10:15 ` Harvey Harrison
2008-01-15 10:25 ` Andi Kleen
2008-01-14 22:16 ` [PATCH] [14/31] CPA: Use page granuality TLB flushing " Andi Kleen
2008-01-14 22:16 ` [PATCH] [15/31] CPA: Don't flush the caches when the CPU supports self-snoop Andi Kleen
2008-01-14 22:16 ` [PATCH] [16/31] CPA: Use wbinvd() macro instead of inline assembly in 64bit c_p_a() Andi Kleen
2008-01-14 22:16 ` [PATCH] [17/31] CPA: Reorder TLB / cache flushes to follow Intel recommendation Andi Kleen
2008-01-14 22:16 ` [PATCH] [18/31] CPA: Make change_page_attr() more robust against use of PAT bits Andi Kleen
2008-01-14 22:16 ` [PATCH] [19/31] CPA: Limit cache flushing to pages that really change caching Andi Kleen
2008-01-15 8:46 ` Jan Beulich
2008-01-14 22:16 ` [PATCH] [20/31] CPA: Fix inaccurate comments in 64bit change_page_attr() Andi Kleen
2008-01-14 22:16 ` [PATCH] [21/31] CPA: Dump pagetable when inconsistency is detected Andi Kleen
2008-01-14 22:16 ` [PATCH] [22/31] CPA: Only queue actually unused page table pages for freeing Andi Kleen
2008-01-14 22:16 ` [PATCH] [23/31] CPA: Remove unnecessary masking of address Andi Kleen
2008-01-14 22:16 ` [PATCH] [24/31] CPA: Only unmap kernel init pages in text mapping when CONFIG_DEBUG_RODATA is set Andi Kleen
2008-01-14 22:16 ` [PATCH] [25/31] CPA: Always do full TLB flush when splitting large pages Andi Kleen
2008-01-14 22:16 ` [PATCH] [26/31] CPA: Fix reference counting when changing already changed pages Andi Kleen
2008-01-15 9:05 ` Jan Beulich
2008-01-15 10:04 ` Andi Kleen
2008-01-15 12:00 ` Jan Beulich
2008-01-14 22:17 ` [PATCH] [27/31] CPA: Change comments of external interfaces to kerneldoc format Andi Kleen
2008-01-14 22:50 ` Randy Dunlap
2008-01-15 0:49 ` Andi Kleen
2008-01-14 22:17 ` [PATCH] [28/31] CPA: Make kernel_text test match boot mapping initialization Andi Kleen
2008-01-14 22:17 ` [PATCH] [29/31] CPA: Add a BUG_ON checking for someone setting the kernel text NX Andi Kleen
2008-01-14 22:17 ` [PATCH] [30/31] Remove set_kernel_exec Andi Kleen
2008-01-14 22:17 ` [PATCH] [31/31] Clean up pte_exec Andi Kleen
2008-01-15 9:11 ` [PATCH] [0/31] Great change_page_attr patch series v2 Jan Beulich
2008-01-15 10:06 ` Andi Kleen
2008-01-15 11:55 ` Jan Beulich
2008-01-15 12:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114221640.437A514F83@wotan.suse.de \
--to=ak@suse.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®